Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 1261923007: [turbofan] Unify referencing of stack slots (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Review feedback Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « BUILD.gn ('k') | src/arm64/lithium-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/arm/lithium-codegen-arm.h" 5 #include "src/arm/lithium-codegen-arm.h"
6 #include "src/arm/lithium-gap-resolver-arm.h" 6 #include "src/arm/lithium-gap-resolver-arm.h"
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/cpu-profiler.h" 10 #include "src/cpu-profiler.h"
(...skipping 629 matching lines...) Expand 10 before | Expand all | Expand 10 after
640 value, 640 value,
641 environment->HasTaggedValueAt(env_offset + i), 641 environment->HasTaggedValueAt(env_offset + i),
642 environment->HasUint32ValueAt(env_offset + i), 642 environment->HasUint32ValueAt(env_offset + i),
643 object_index_pointer, 643 object_index_pointer,
644 dematerialized_index_pointer); 644 dematerialized_index_pointer);
645 } 645 }
646 return; 646 return;
647 } 647 }
648 648
649 if (op->IsStackSlot()) { 649 if (op->IsStackSlot()) {
650 int index = op->index();
651 if (index >= 0) {
652 index += StandardFrameConstants::kFixedFrameSize / kPointerSize;
653 }
650 if (is_tagged) { 654 if (is_tagged) {
651 translation->StoreStackSlot(op->index()); 655 translation->StoreStackSlot(index);
652 } else if (is_uint32) { 656 } else if (is_uint32) {
653 translation->StoreUint32StackSlot(op->index()); 657 translation->StoreUint32StackSlot(index);
654 } else { 658 } else {
655 translation->StoreInt32StackSlot(op->index()); 659 translation->StoreInt32StackSlot(index);
656 } 660 }
657 } else if (op->IsDoubleStackSlot()) { 661 } else if (op->IsDoubleStackSlot()) {
658 translation->StoreDoubleStackSlot(op->index()); 662 int index = op->index();
663 if (index >= 0) {
664 index += StandardFrameConstants::kFixedFrameSize / kPointerSize;
665 }
666 translation->StoreDoubleStackSlot(index);
659 } else if (op->IsRegister()) { 667 } else if (op->IsRegister()) {
660 Register reg = ToRegister(op); 668 Register reg = ToRegister(op);
661 if (is_tagged) { 669 if (is_tagged) {
662 translation->StoreRegister(reg); 670 translation->StoreRegister(reg);
663 } else if (is_uint32) { 671 } else if (is_uint32) {
664 translation->StoreUint32Register(reg); 672 translation->StoreUint32Register(reg);
665 } else { 673 } else {
666 translation->StoreInt32Register(reg); 674 translation->StoreInt32Register(reg);
667 } 675 }
668 } else if (op->IsDoubleRegister()) { 676 } else if (op->IsDoubleRegister()) {
(...skipping 5348 matching lines...) Expand 10 before | Expand all | Expand 10 after
6017 __ push(ToRegister(instr->function())); 6025 __ push(ToRegister(instr->function()));
6018 CallRuntime(Runtime::kPushBlockContext, 2, instr); 6026 CallRuntime(Runtime::kPushBlockContext, 2, instr);
6019 RecordSafepoint(Safepoint::kNoLazyDeopt); 6027 RecordSafepoint(Safepoint::kNoLazyDeopt);
6020 } 6028 }
6021 6029
6022 6030
6023 #undef __ 6031 #undef __
6024 6032
6025 } // namespace internal 6033 } // namespace internal
6026 } // namespace v8 6034 } // namespace v8
OLDNEW
« no previous file with comments | « BUILD.gn ('k') | src/arm64/lithium-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698