Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 1261923003: Fix segv above CPDFSDK_Document::GetPageView() (Closed)

Created:
5 years, 4 months ago by Tom Sepez
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix segv above CPDFSDK_Document::GetPageView() The refactoring at fb07e28 removed a null handle check. BUG=514690 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d1a588c6ce03425773594381a0966434016813b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M fpdfsdk/src/fpdfformfill.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M fpdfsdk/src/fpdfformfill_embeddertest.cpp View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, for review. The test repros the same crash without the corresponding patch. Thanks.
5 years, 4 months ago (2015-07-28 17:37:36 UTC) #2
Lei Zhang
lgtm
5 years, 4 months ago (2015-07-28 17:38:51 UTC) #3
Tom Sepez
5 years, 4 months ago (2015-07-28 18:08:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d1a588c6ce03425773594381a0966434016813b1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698