Issue 1261923003: Fix segv above CPDFSDK_Document::GetPageView()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1261923003: Fix segv above CPDFSDK_Document::GetPageView() (Closed)

Created:
5 years, 4 months ago by Tom Sepez

Modified:
5 years, 4 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix segv above CPDFSDK_Document::GetPageView() The refactoring at fb07e28 removed a null handle check. BUG=514690 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d1a588c6ce03425773594381a0966434016813b1

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	fpdfsdk/src/fpdfformfill.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	fpdfsdk/src/fpdfformfill_embeddertest.cpp	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

Lei, for review. The test repros the same crash without the corresponding patch. Thanks.

5 years, 4 months ago (2015-07-28 17:37:36 UTC) #2

Tom Sepez

5 years, 4 months ago (2015-07-28 18:08:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d1a588c6ce03425773594381a0966434016813b1 (presubmit successful).