Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1261893002: customtabs: Allows CustomTabsConnection to be subclassed. (Closed)

Created:
5 years, 4 months ago by Benoit L
Modified:
5 years, 4 months ago
Reviewers:
Ian Wen, Yusuf, Maria
CC:
chromium-reviews, ianwen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

customtabs: Allows CustomTabsConnection to be subclassed. This change makes it possible to provide a Service derived from CustomTabsConnectionService and make some fields and methods protected in CustomTabsConnection. BUG=504479 Committed: https://crrev.com/489d4df5dd88d0227b09d56cf090a55f3ccadd08 Cr-Commit-Position: refs/heads/master@{#342351}

Patch Set 1 #

Patch Set 2 : Simplify using ChromeApplication to choose the appropriate subclass. #

Patch Set 3 : Update AIDL and add extraCommand / extraCallback #

Patch Set 4 : Rebase. #

Total comments: 2

Patch Set 5 : Rebase and add javadoc. #

Patch Set 6 : Silence findbugs warning. #

Messages

Total messages: 17 (7 generated)
Benoit L
5 years, 4 months ago (2015-07-30 09:39:09 UTC) #2
Yusuf
lgtm
5 years, 4 months ago (2015-07-31 06:17:10 UTC) #3
Benoit L
Hello mariakhomenko, Can you please review the change to ChromeApplication? Need OWNERS approval. Thanks!
5 years, 4 months ago (2015-08-06 12:19:25 UTC) #5
Maria
lgtm https://codereview.chromium.org/1261893002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java (right): https://codereview.chromium.org/1261893002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java#newcode681 chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java:681: public CustomTabsConnection createCustomTabsConnection() { please add javadoc
5 years, 4 months ago (2015-08-06 20:39:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261893002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261893002/80001
5 years, 4 months ago (2015-08-07 12:14:31 UTC) #9
Benoit L
https://codereview.chromium.org/1261893002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java (right): https://codereview.chromium.org/1261893002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java#newcode681 chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java:681: public CustomTabsConnection createCustomTabsConnection() { On 2015/08/06 20:39:11, Maria wrote: ...
5 years, 4 months ago (2015-08-07 12:14:44 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/106067)
5 years, 4 months ago (2015-08-07 12:45:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261893002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261893002/100001
5 years, 4 months ago (2015-08-07 13:33:20 UTC) #15
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 4 months ago (2015-08-07 14:10:47 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 14:11:23 UTC) #17
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/489d4df5dd88d0227b09d56cf090a55f3ccadd08
Cr-Commit-Position: refs/heads/master@{#342351}

Powered by Google App Engine
This is Rietveld 408576698