Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1261863003: [Telemetry] Fix up desktop_browser_finder on Linux (Closed)

Created:
5 years, 4 months ago by eakuefner
Modified:
5 years, 4 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Fix up desktop_browser_finder on Linux This CL adds {stable, beta, dev} browsers on Linux, as well as fixes the bug where if a user has stable installed but beta or dev default, browser 'system' would refer to stable unconditionally. Unit tests have been expanded both to verify the bugfix and new features. BUG=515286, 515295 R=aiolos@chromium.org,dtu,nednguyen TEST=perf/run_benchmark --browser {system,stable,beta,dev} sunspider and telemetry/run_tests desktop_browser_finder Committed: https://crrev.com/202b18768443abd15ddc6b5f47873f8e4415b38b Cr-Commit-Position: refs/heads/master@{#341196}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Ned's comment #

Patch Set 3 : reflow #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -12 lines) Patch
M tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py View 1 2 2 chunks +22 lines, -12 lines 0 comments Download
M tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder_unittest.py View 3 chunks +18 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/testing/system_stub.py View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
eakuefner
PTAL
5 years, 4 months ago (2015-07-30 18:12:47 UTC) #1
nednguyen
lgtm https://codereview.chromium.org/1261863003/diff/1/tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py File tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py (right): https://codereview.chromium.org/1261863003/diff/1/tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py#newcode246 tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py:246: root = os.path.split(os.path.realpath('google-chrome'))[0] Fix this
5 years, 4 months ago (2015-07-30 20:06:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261863003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261863003/40001
5 years, 4 months ago (2015-07-30 20:17:11 UTC) #5
eakuefner
https://codereview.chromium.org/1261863003/diff/1/tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py File tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py (right): https://codereview.chromium.org/1261863003/diff/1/tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py#newcode246 tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py:246: root = os.path.split(os.path.realpath('google-chrome'))[0] On 2015/07/30 at 20:06:45, nednguyen wrote: ...
5 years, 4 months ago (2015-07-30 20:27:12 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-07-30 21:29:19 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 21:30:00 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/202b18768443abd15ddc6b5f47873f8e4415b38b
Cr-Commit-Position: refs/heads/master@{#341196}

Powered by Google App Engine
This is Rietveld 408576698