src/arm64/lithium-codegen-arm64.cc - Issue 1261863002: [runtime] DeclareGlobals and DeclareLookupSlot don't need context parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/lithium-codegen-arm64.cc

Issue 1261863002: [runtime] DeclareGlobals and DeclareLookupSlot don't need context parameters. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix x64 typo. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm64/lithium-codegen-arm64.cc

diff --git a/src/arm64/lithium-codegen-arm64.cc b/src/arm64/lithium-codegen-arm64.cc

index 3a2ef8f6a94c030900cc323a6e5f1f458b6f0a85..6fb1088efc71e9b6b27ff9e52c61e2b24369f44c 100644

--- a/src/arm64/lithium-codegen-arm64.cc

+++ b/src/arm64/lithium-codegen-arm64.cc

@@ -5035,8 +5035,8 @@ void LCodeGen::DoDeclareGlobals(LDeclareGlobals* instr) {

// here.

__ LoadHeapObject(scratch1, instr->hydrogen()->pairs());

__ Mov(scratch2, Smi::FromInt(instr->hydrogen()->flags()));

- __ Push(cp, scratch1, scratch2); // The context is the first argument.

- CallRuntime(Runtime::kDeclareGlobals, 3, instr);

+ __ Push(scratch1, scratch2);

+ CallRuntime(Runtime::kDeclareGlobals, 2, instr);

}

« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/compiler/ast-graph-builder.cc » ('j') | no next file with comments »