chrome/browser/extensions/extension_action_manager.cc - Issue 12618009: Move SystemIndicator parsing out of Extension class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_action_manager.cc

Issue 12618009: Move SystemIndicator parsing out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_action_manager.cc

diff --git a/chrome/browser/extensions/extension_action_manager.cc b/chrome/browser/extensions/extension_action_manager.cc

index c60383e1599780a8c63eb8bfd9b1fc8e204cfaf5..2dd3a27e8ba630bf46d4bccf3f66bb15606c1480 100644

--- a/chrome/browser/extensions/extension_action_manager.cc

+++ b/chrome/browser/extensions/extension_action_manager.cc

@@ -155,7 +155,7 @@ ExtensionAction* ExtensionActionManager::GetSystemIndicator(

return GetOrCreateOrNull(&system_indicators_, extension.id(),

ActionInfo::TYPE_SYSTEM_INDICATOR,

- extension.system_indicator_info());

+ ActionInfo::GetSystemIndicatorInfo(&extension));

}

ExtensionAction* ExtensionActionManager::GetScriptBadge(