Issue 1261783005: fixes #197, don't generate casts that always pass

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1261783005: fixes #197, don't generate casts that always pass (Closed)

Created:
5 years, 4 months ago by Jennifer Messerly

Modified:
5 years, 4 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+257 lines, -254 lines)			Patch
M	lib/src/codegen/js_codegen.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/codegen/expect/js_test.txt	View	1 chunk	+249 lines, -249 lines	0 comments	Download
M	test/codegen/expect/sunflower/sunflower.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/codegen/expect/unittest.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/codegen/expect/unittest/unittest.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

Jennifer Messerly

5 years, 4 months ago (2015-08-04 22:42:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8896619b55e1eb1b4af10d272cca170f533a38bb (presubmit successful).