Issue 1261783003: Serialize Notification.direction == "auto" in the database.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1261783003: Serialize Notification.direction == "auto" in the database. (Closed)

Created:
5 years, 4 months ago by Peter Beverloo

Modified:
5 years, 4 months ago

Reviewers:
johnme

CC:
blink-reviews, peter+watch_chromium.org, dglazkov+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Serialize Notification.direction == "auto" in the database (1/3). The "auto" value should be reflected in recreated Notification objects just like we reflect ltr and rtl. BUG=516339 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199902

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	public/platform/modules/notifications/WebNotificationData.h	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261783003/1

5 years, 4 months ago (2015-08-03 15:52:23 UTC) #4

commit-bot: I haz the power

5 years, 4 months ago (2015-08-03 17:14:53 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199902

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages