Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1261773002: change getBounds to return 0000 iff there are zero points (Closed)

Created:
5 years, 4 months ago by reed1
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

change getBounds to return 0000 iff there are zero points This is a contract change for SkPath::getBounds(), which formally was defined to return 0,0,0,0 for a 1-point path, regardless of the coordinates of that point. This seems wacky/inconsistent, and was causing other bugs (incorrect bounds) when this was unioned with other rects. Does anyone remember why we defined it this way? BUG=513799 Committed: https://skia.googlesource.com/skia/+/91f283bb4e6ea71bbd4e6efc27befc29118ee543

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -14 lines) Patch
M include/core/SkPath.h View 1 chunk +6 lines, -5 lines 0 comments Download
M include/core/SkPathRef.h View 1 chunk +1 line, -7 lines 0 comments Download
M tests/PathTest.cpp View 3 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
reed1
5 years, 4 months ago (2015-07-27 21:06:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261773002/1
5 years, 4 months ago (2015-07-27 21:07:56 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-27 21:15:40 UTC) #6
reed1
ptal
5 years, 4 months ago (2015-07-27 21:52:08 UTC) #7
f(malita)
On 2015/07/27 21:52:08, reed1 wrote: > ptal Not familiar with the original motivation, but this ...
5 years, 4 months ago (2015-07-27 21:59:14 UTC) #8
caryclark
lgtm
5 years, 4 months ago (2015-07-28 12:11:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261773002/1
5 years, 4 months ago (2015-07-28 13:00:05 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 13:00:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/91f283bb4e6ea71bbd4e6efc27befc29118ee543

Powered by Google App Engine
This is Rietveld 408576698