Issue 1261743002: Revert of Lay groundwork for SkOpts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1261743002: Revert of Lay groundwork for SkOpts. (Closed)

Created:
5 years, 4 months ago by mtklein_C

Modified:
5 years, 4 months ago

Reviewers:
djsollen

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Lay groundwork for SkOpts. (patchset #3 id:40001 of https://codereview.chromium.org/1255193002/) Reason for revert: Chromium doesn't call SkGraphics::Init(). This setup won't work. Original issue's description: > Lay groundwork for SkOpts. > > This doesn't really do anything yet. It's just the CPU detection code, skeleton new .cpp files, and a few little .gyp tweaks. > > BUG=skia:4117 > > Committed: https://skia.googlesource.com/skia/+/ce2c5055cee5d5d3c9fc84c1b3eeed4b4d84a827 TBR=djsollen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4117 Committed: https://skia.googlesource.com/skia/+/56b78a7a2aa87998e6a3f3d026e2184f1bccaf0c

Patch Set 1 #

Created: 5 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -135 lines)			Patch
M	gyp/core.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gyp/opts.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gyp/opts.gypi	View	3 chunks	+0 lines, -5 lines	0 comments	Download
M	src/core/SkGraphics.cpp	View	2 chunks	+0 lines, -2 lines	0 comments	Download
D	src/core/SkOpts.h	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	src/core/SkOpts.cpp	View	1 chunk	+0 lines, -48 lines	0 comments	Download
D	src/opts/SkOpts_neon.cpp	View	1 chunk	+0 lines, -14 lines	0 comments	Download
D	src/opts/SkOpts_sse2.cpp	View	1 chunk	+0 lines, -14 lines	0 comments	Download
D	src/opts/SkOpts_sse41.cpp	View	1 chunk	+0 lines, -14 lines	0 comments	Download
D	src/opts/SkOpts_ssse3.cpp	View	1 chunk	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261743002/1

5 years, 4 months ago (2015-07-27 19:03:14 UTC) #2

commit-bot: I haz the power

5 years, 4 months ago (2015-07-27 19:03:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/56b78a7a2aa87998e6a3f3d026e2184f1bccaf0c

Expand Messages | Collapse Messages