Issue 12617019: Add display scaling and rotation shortcuts to keyboard overlay.

Issue 12617019: Add display scaling and rotation shortcuts to keyboard overlay. (Closed)

Created:
7 years, 9 months ago by mazda

Modified:
7 years, 9 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add display scaling and rotation shortcuts to keyboard overlay. Ctrl-Shift-Back -> Scale down UI Ctrl-Shift-Foward -> Scale up UI Ctrl-Shift-Reload -> Rotate screen BUG=196817 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190538

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Use AddBoolean #

Patch Set 4 : change strings #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -9 lines)			Patch
M	chrome/app/chromeos_strings.grdp	View	1 2 3	2 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/chromeos/keyboard_overlay.js	View	1 2 3	2 chunks	+30 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/chromeos/keyboard_overlay_data.js	View	1 2 3	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc	View	1 2 3	4 chunks	+15 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

mazda

Could you review this CL? The strings for the shortcut is being reviewed by Kuscher@ ...

7 years, 9 months ago (2013-03-23 05:07:39 UTC) #1

xiyuan

LGTM with one nit. https://codereview.chromium.org/12617019/diff/2001/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc File chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc (right): https://codereview.chromium.org/12617019/diff/2001/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc#newcode264 chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc:264: "true" : "false"); nit: you ...

7 years, 9 months ago (2013-03-23 05:49:09 UTC) #2

mazda

https://codereview.chromium.org/12617019/diff/2001/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc File chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc (right): https://codereview.chromium.org/12617019/diff/2001/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc#newcode264 chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc:264: "true" : "false"); On 2013/03/23 05:49:09, xiyuan wrote: > ...

7 years, 9 months ago (2013-03-23 06:28:45 UTC) #3

mazda

Changed the string and shortcuts as follows based on UI review. Ctrl Shift +: Zoom ...

7 years, 9 months ago (2013-03-26 01:05:34 UTC) #5

mazda

Committed patchset #4 manually as r190538 (presubmit successful).

7 years, 9 months ago (2013-03-26 01:10:53 UTC) #6

mazda

7 years, 9 months ago (2013-03-26 01:13:59 UTC) #7

Message was sent while issue was closed.

On 2013/03/26 01:10:53, mazda wrote:
> Committed patchset #4 manually as r190538 (presubmit successful).

Oops, I forgot to modify the description...
Followings are correct.

Ctrl Shift + -> Zoom screen in
Ctrl Shift - -> Zoom screen out
Ctrl Shift 0 -> Reset screen zoom
Ctrl Shift reload -> Rotate screen

Expand Messages | Collapse Messages