runtime/vm/flow_graph_type_propagator.cc - Issue 1261673004: Non-tree-shaking --precompile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 1261673004: Non-tree-shaking --precompile. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_type_propagator.cc

diff --git a/runtime/vm/flow_graph_type_propagator.cc b/runtime/vm/flow_graph_type_propagator.cc

index f22c50f2dd8a72a69d81374b73d30a75cbc2f372..6fcd8742810a6c0c34c74da5a31903bb2f6ad781 100644

--- a/runtime/vm/flow_graph_type_propagator.cc

+++ b/runtime/vm/flow_graph_type_propagator.cc

@@ -1038,10 +1038,9 @@ CompileType LoadFieldInstr::ComputeType() const {

}

const AbstractType* abstract_type = NULL;

- if (Isolate::Current()->flags().type_checks()) {

- ASSERT(!type().HasResolvedTypeClass() ||

- !Field::IsExternalizableCid(Class::Handle(

- type().type_class()).id()));

+ if (Isolate::Current()->flags().type_checks() &&

rmacnak 2015/07/29 19:30:38 First closurization of methods in TwoByteString et

+ type().HasResolvedTypeClass() &&

+ !Field::IsExternalizableCid(Class::Handle(type().type_class()).id())) {

abstract_type = &type();

}