Handle Smart Lock for Android promotion screen.

Handle Smart Lock for Android promotion screen.

This CL also introduces some sleeps to resolve UI race conditions.

Committed: https://crrev.com/2121ad985525090fa7bc834ff9c0aa38668dc039
Cr-Commit-Position: refs/heads/master@{#341642}

[vsankar, 2015-08-03 20:37:19]

vsankar@google.com changed reviewers:
+ tengs@chromium.org

[vsankar, 2015-08-03 20:37:19]

Please take a look

[Tim Song, 2015-08-03 21:42:19]

Thanks, Sankar. A few comments:

https://codereview.chromium.org/1261643006/diff/1/components/proximity_auth/e...
File components/proximity_auth/e2e_test/cros.py (right):

https://codereview.chromium.org/1261643006/diff/1/components/proximity_auth/e...
components/proximity_auth/e2e_test/cros.py:288: assert(
The PROMOTE_SMARTLOCK_FOR_ANDROID state doesn't always show up. You should wrap
this in an if-statement rather than an assert.

https://codereview.chromium.org/1261643006/diff/1/components/proximity_auth/e...
components/proximity_auth/e2e_test/cros.py:319: time.sleep(2)
Can you reduce the time to 1 second? I think that should still be sufficient to
work around the race conditions.

https://codereview.chromium.org/1261643006/diff/1/components/proximity_auth/e...
File components/proximity_auth/e2e_test/setup_test.py (right):

https://codereview.chromium.org/1261643006/diff/1/components/proximity_auth/e...
components/proximity_auth/e2e_test/setup_test.py:156: raise
SmartLockSetupError('Failed to obtain app set up window')
nit: reword to "Failed to obtain setup app window."

[vsankar, 2015-08-03 22:32:13]

https://codereview.chromium.org/1261643006/diff/1/components/proximity_auth/e...
File components/proximity_auth/e2e_test/cros.py (right):

https://codereview.chromium.org/1261643006/diff/1/components/proximity_auth/e...
components/proximity_auth/e2e_test/cros.py:288: assert(
On 2015/08/03 21:42:19, Tim Song wrote:
> The PROMOTE_SMARTLOCK_FOR_ANDROID state doesn't always show up. You should
wrap
> this in an if-statement rather than an assert.

Done.

https://codereview.chromium.org/1261643006/diff/1/components/proximity_auth/e...
components/proximity_auth/e2e_test/cros.py:319: time.sleep(2)
On 2015/08/03 21:42:18, Tim Song wrote:
> Can you reduce the time to 1 second? I think that should still be sufficient
to
> work around the race conditions.

Done.

https://codereview.chromium.org/1261643006/diff/1/components/proximity_auth/e...
File components/proximity_auth/e2e_test/setup_test.py (right):

https://codereview.chromium.org/1261643006/diff/1/components/proximity_auth/e...
components/proximity_auth/e2e_test/setup_test.py:156: raise
SmartLockSetupError('Failed to obtain app set up window')
On 2015/08/03 21:42:19, Tim Song wrote:
> nit: reword to "Failed to obtain setup app window."

Done.

[Tim Song, 2015-08-03 23:26:37]

LGTM

[Tim Song, 2015-08-03 23:26:42]

The CQ bit was checked by tengs@chromium.org

[commit-bot: I haz the power, 2015-08-03 23:27:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1261643006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1261643006/20001

[commit-bot: I haz the power, 2015-08-03 23:35:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-03 23:35:51]

Patchset 2 (id:??) landed as
https://crrev.com/2121ad985525090fa7bc834ff9c0aa38668dc039
Cr-Commit-Position: refs/heads/master@{#341642}