Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1261643002: Remove unnecessary condition for audioSourceProvider (Closed)

Created:
5 years, 4 months ago by Srirama
Modified:
5 years, 2 months ago
CC:
blink-reviews, nessy, mlamouri+watch-blink_chromium.org, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove unnecessary condition for audioSourceProvider Change audioSourceProvider to return reference so that it will never be null. This allows to remove the unnecessary conditions. Committed: https://crrev.com/969bf4fbb54129362114ad337ebe22eb5f200506 git-svn-id: svn://svn.chromium.org/blink/trunk@199518 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : change audioSourceProvider to return reference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -35 lines) Patch
M Source/core/html/HTMLMediaElement.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 4 chunks +5 lines, -7 lines 0 comments Download
M Source/modules/webaudio/MediaElementAudioSourceNode.cpp View 1 1 chunk +22 lines, -27 lines 0 comments Download

Messages

Total messages: 16 (3 generated)
Srirama
PTAL
5 years, 4 months ago (2015-07-27 14:06:18 UTC) #2
philipj_slow
There's also a redundant null check in modules/webaudio: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp&sq=package:chromium&type=cs&l=166&rcl=1437751877 Can you instead let this getter ...
5 years, 4 months ago (2015-07-27 14:12:30 UTC) #3
Srirama
On 2015/07/27 14:12:30, philipj wrote: > There's also a redundant null check in modules/webaudio: > ...
5 years, 4 months ago (2015-07-27 14:42:18 UTC) #4
philipj_slow
HTMLMediaElement LGTM rtoy@, can you please review modules/webaudio?
5 years, 4 months ago (2015-07-27 15:29:29 UTC) #6
Raymond Toy
On 2015/07/27 15:29:29, philipj wrote: > HTMLMediaElement LGTM > > rtoy@, can you please review ...
5 years, 4 months ago (2015-07-27 16:32:12 UTC) #7
Srirama
On 2015/07/27 16:32:12, Raymond Toy wrote: > On 2015/07/27 15:29:29, philipj wrote: > > HTMLMediaElement ...
5 years, 4 months ago (2015-07-27 16:46:07 UTC) #8
Raymond Toy
On 2015/07/27 16:46:07, Srirama wrote: > On 2015/07/27 16:32:12, Raymond Toy wrote: > > On ...
5 years, 4 months ago (2015-07-27 16:47:22 UTC) #9
Raymond Toy
On 2015/07/27 16:47:22, Raymond Toy wrote: > On 2015/07/27 16:46:07, Srirama wrote: > > On ...
5 years, 4 months ago (2015-07-27 17:03:26 UTC) #10
Srirama
On 2015/07/27 17:03:26, Raymond Toy wrote: > On 2015/07/27 16:47:22, Raymond Toy wrote: > > ...
5 years, 4 months ago (2015-07-27 17:07:55 UTC) #11
Raymond Toy
On 2015/07/27 17:07:55, Srirama wrote: > On 2015/07/27 17:03:26, Raymond Toy wrote: > > On ...
5 years, 4 months ago (2015-07-27 17:16:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261643002/20001
5 years, 4 months ago (2015-07-27 17:21:04 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=199518
5 years, 4 months ago (2015-07-27 17:23:55 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 11:48:51 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/969bf4fbb54129362114ad337ebe22eb5f200506

Powered by Google App Engine
This is Rietveld 408576698