Issue 126163003: Rename setUninstallUrl to setUninstallURL throughout codebase

Issue 126163003: Rename setUninstallUrl to setUninstallURL throughout codebase (Closed)

Created:
6 years, 11 months ago by jshumway

Modified:
6 years, 11 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -15 lines)			Patch
M	chrome/browser/extensions/api/runtime/runtime_api.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/api/runtime/runtime_api.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/api/runtime/runtime_apitest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_function_registry.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/api/_api_features.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/api/runtime.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/runtime/uninstall_url/sets_uninstall_url/bg.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/runtime/uninstall_url/test.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 7 (0 generated)

Yoyo Zhou

LGTM, but your CL description is the opposite of what you intended.

6 years, 11 months ago (2014-01-07 19:00:20 UTC) #2

jshumway

On 2014/01/07 19:00:20, Yoyo Zhou wrote: > LGTM, but your CL description is the opposite ...

6 years, 11 months ago (2014-01-07 19:03:07 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jaredshumway94@gmail.com/126163003/1

6 years, 11 months ago (2014-01-07 19:06:16 UTC) #4

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242615

6 years, 11 months ago (2014-01-07 20:09:06 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jaredshumway94@gmail.com/126163003/1

6 years, 11 months ago (2014-01-10 01:27:04 UTC) #6

Message was sent while issue was closed.

Change committed as 244061