Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 1261623002: Add AccessSemantics.INVALID for invalid expressions. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/resolved_visitor.dart ('k') | tests/compiler/dart2js/semantic_visitor_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index e3cb4b8d7da65c624767601c97c750cc201c07c7..1655d90fdc0a2d2a0f5c2c9ff601641464fda230 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -1040,7 +1040,8 @@ class SsaBuilder extends ast.Visitor
with BaseImplementationOfCompoundsMixin,
SendResolverMixin,
SemanticSendResolvedMixin,
- NewBulkMixin
+ NewBulkMixin,
+ ErrorBulkMixin
implements SemanticSendVisitor {
final Compiler compiler;
final JavaScriptBackend backend;
@@ -8276,6 +8277,12 @@ class SsaBuilder extends ast.Visitor
_) {
visitNode(node);
}
+
+ @override
+ void bulkHandleError(ast.Node node, ErroneousElement error, _) {
+ // TODO(johnniwinther): Use an uncatchable error when supported.
+ generateRuntimeError(node, error.message);
+ }
}
/**
« no previous file with comments | « pkg/compiler/lib/src/resolved_visitor.dart ('k') | tests/compiler/dart2js/semantic_visitor_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698