Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1261603002: Revert of Debugger: correctly redirect eval code. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
mvstanton
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Debugger: correctly redirect eval code. (patchset #2 id:20001 of https://codereview.chromium.org/1258583002/) Reason for revert: Causes hang: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20sim%20-%20novfp3/builds/1446 Original issue's description: > Debugger: correctly redirect eval code. > > This also allows us to not always compile for debugging when debug is active. > > Committed: https://crrev.com/0cae607ff33725e868a217556a88ac4478774210 > Cr-Commit-Position: refs/heads/master@{#29848} TBR=mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/d2b4133c722a8e6a19ba460e534b0b8546f47a8c Cr-Commit-Position: refs/heads/master@{#29862}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/compiler.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Created Revert of Debugger: correctly redirect eval code.
5 years, 4 months ago (2015-07-27 08:05:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261603002/1
5 years, 4 months ago (2015-07-27 08:05:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-27 08:05:54 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 08:06:21 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2b4133c722a8e6a19ba460e534b0b8546f47a8c
Cr-Commit-Position: refs/heads/master@{#29862}

Powered by Google App Engine
This is Rietveld 408576698