Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4766)

Unified Diff: chrome/test/chromedriver/run_py_tests.py

Issue 12616009: [chromedriver] Disable testAlert, it is flaky. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/run_py_tests.py
diff --git a/chrome/test/chromedriver/run_py_tests.py b/chrome/test/chromedriver/run_py_tests.py
index 90e553e9269dcd9723896b36050b35793b6085c3..64732b3b67ce67f45c3425039782206806d2c070 100755
--- a/chrome/test/chromedriver/run_py_tests.py
+++ b/chrome/test/chromedriver/run_py_tests.py
@@ -26,6 +26,10 @@ from common import chrome_paths
from common import unittest_util
+def Skip(func):
+ pass
+
+
class ChromeDriverBaseTest(unittest.TestCase):
"""Base class for testing chromedriver functionalities."""
@@ -343,9 +347,11 @@ class ChromeDriverTest(ChromeDriverBaseTest):
self._driver.MouseDoubleClick()
self.assertEquals(1, len(self._driver.FindElements('tag name', 'br')))
+ # TODO(kkania): This test is flaky since it uses setTimeout.
+ # Re-enable once crbug.com/177511 is fixed and we can remove setTimeout.
+ @Skip
def testAlert(self):
self.assertFalse(self._driver.IsAlertOpen())
- # TODO(kkania): Don't use setTimeout once crbug.com/177511 is fixed.
div = self._driver.ExecuteScript(
'window.setTimeout('
' function() { window.confirmed = confirm(\'HI\'); },'
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698