Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1261593004: bluetooth: Add histograms and logging for requestDevice() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-adapter-ff
Patch Set: Address asvitkine comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 569331352883e3b27475216bd11dafb91988b97f..4f1c1f05cf5aa1fb25283c065a2c5144787702ff 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -2719,8 +2719,75 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
-<histogram name="Bluetooth.RequestDevice.Outcome"
Alexei Svitkine (slow) 2015/08/10 22:03:36 It's better to mark the existing histogram <obsole
ortuno 2015/08/11 20:10:55 Done.
- enum="BluetoothRequestDeviceOutcome">
+<histogram name="Bluetooth.Web.FunctionCall.Count" enum="WebBluetoothFunction">
+ <owner>jyasskin@chromium.org</owner>
+ <owner>ortuno@chromium.org</owner>
+ <owner>scheib@chromium.org</owner>
+ <summary>
+ Counts the number of times each call to a WebBluetooth function is done.
+ </summary>
+</histogram>
+
+<histogram name="Bluetooth.Web.RequestDevice.Filters.Count" units="filters">
+ <owner>jyasskin@chromium.org</owner>
+ <owner>ortuno@chromium.org</owner>
+ <owner>scheib@chromium.org</owner>
+ <summary>
+ Records how many filters are used when scanning. This results will help us
+ better understand the uses of the API and make changes according to
+ developers' behavior.
+ </summary>
+</histogram>
+
+<histogram name="Bluetooth.Web.RequestDevice.Filters.Services"
+ enum="GATTServices">
+ <owner>jyasskin@chromium.org</owner>
+ <owner>ortuno@chromium.org</owner>
+ <owner>scheib@chromium.org</owner>
+ <summary>
+ Records what GATT Services are used when scanning. This will help us know if
+ we should build an API for specific services rather than a general Bluetooth
+ API.
+ </summary>
+</histogram>
+
+<histogram name="Bluetooth.Web.RequestDevice.FilterSize" units="services">
+ <owner>jyasskin@chromium.org</owner>
+ <owner>ortuno@chromium.org</owner>
+ <owner>scheib@chromium.org</owner>
+ <summary>
+ Records how many filters services are used in a filter. This results will
+ help us better understand the uses of the API and make changes according to
+ developers' behavior.
+ </summary>
+</histogram>
+
+<histogram name="Bluetooth.Web.RequestDevice.OptionalServices.Count"
+ units="filters">
+ <owner>jyasskin@chromium.org</owner>
+ <owner>ortuno@chromium.org</owner>
+ <owner>scheib@chromium.org</owner>
+ <summary>
+ Records how many optional services are used when scanning. This results will
+ help us better understand the uses of the API and make changes according to
+ developers' behavior.
+ </summary>
+</histogram>
+
+<histogram name="Bluetooth.Web.RequestDevice.OptionalServices.Services"
+ units="GATTServices">
+ <owner>jyasskin@chromium.org</owner>
+ <owner>ortuno@chromium.org</owner>
+ <owner>scheib@chromium.org</owner>
+ <summary>
+ Records how many optional services are used when scanning. This results will
+ help us better understand the uses of the API and make changes according to
+ developers' behavior.
+ </summary>
+</histogram>
+
+<histogram name="Bluetooth.Web.RequestDevice.Outcome"
+ enum="WebBluetoothRequestDeviceOutcome">
<owner>jyasskin@chromium.org</owner>
<owner>ortuno@chromium.org</owner>
<owner>scheib@chromium.org</owner>
@@ -2731,12 +2798,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
-<histogram name="Bluetooth.Web.FunctionCall.Count" enum="WebBluetoothFunction">
+<histogram name="Bluetooth.Web.RequestDevice.UnionOfServices.Count"
+ units="services">
<owner>jyasskin@chromium.org</owner>
<owner>ortuno@chromium.org</owner>
<owner>scheib@chromium.org</owner>
<summary>
- Counts the number of times each call to a WebBluetooth function is done.
+ Records how many services are used when scanning. This results will help us
+ better understand the uses of the API and make changes according to
+ developers' behavior.
</summary>
</histogram>
@@ -51781,17 +51851,6 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="8" label="Unknown or unhandler error"/>
</enum>
-<enum name="BluetoothRequestDeviceOutcome" type="int">
- <int value="0" label="Success"/>
- <int value="1" label="No Bluetooth adapter"/>
- <int value="2" label="No RenderFrameHost for message source"/>
- <int value="3" label="Discovery start failed"/>
- <int value="4" label="Discovery stop failed"/>
- <int value="5" label="No matching devices found"/>
- <int value="6" label="Bluetooth Adapter not present"/>
- <int value="7" label="Bluetooth Adapter was off"/>
-</enum>
-
<enum name="BookmarksExperimentState" type="int">
<int value="0" label="No experiment"/>
<int value="1" label="Experiment enabled (sync)"/>
@@ -59000,6 +59059,45 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="8" label="Overflow"/>
</enum>
+<enum name="GATTServices" type="int">
+ <int value="00" label="Unknown Service"/>
+ <int value="01" label="generic_access"/>
+ <int value="02" label="generic_attribute"/>
+ <int value="03" label="immediate_alert"/>
+ <int value="04" label="link_loss"/>
+ <int value="05" label="tx_power"/>
+ <int value="06" label="current_time"/>
+ <int value="07" label="reference_time_update"/>
+ <int value="08" label="next_dst_change"/>
+ <int value="09" label="glucose"/>
+ <int value="10" label="health_thermometer"/>
+ <int value="11" label="device_information"/>
+ <int value="12" label="Reserved for future use"/>
+ <int value="13" label="Reserved for future use"/>
+ <int value="14" label="heart_rate"/>
+ <int value="15" label="phone_alert_status"/>
+ <int value="16" label="battery_service"/>
+ <int value="17" label="blood_pressure"/>
+ <int value="18" label="alert_notification"/>
+ <int value="19" label="human_interface_device"/>
+ <int value="20" label="scan_parameters"/>
+ <int value="21" label="running_speed_and_cadence"/>
+ <int value="22" label="automation_io"/>
+ <int value="23" label="cycling_speed_and_cadence"/>
+ <int value="24" label="Reserved for future use"/>
+ <int value="25" label="cycling_power"/>
+ <int value="26" label="location_and_navigation"/>
+ <int value="27" label="environmental_sensing"/>
+ <int value="28" label="body_composition"/>
+ <int value="29" label="user_data"/>
+ <int value="30" label="weight_scale"/>
+ <int value="31" label="bond_management"/>
+ <int value="32" label="continuous_glucose_monitoring"/>
+ <int value="33" label="internet_protocol_support"/>
+ <int value="34" label="indoor_positioning"/>
+ <int value="35" label="pulse_oximeter"/>
+</enum>
+
<enum name="GCMCheckinRequestStatus" type="int">
<int value="0" label="Success"/>
<int value="1" label="URL fetching failed"/>
@@ -71271,6 +71369,17 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="5" label="Characteristic.writeValue()"/>
</enum>
+<enum name="WebBluetoothRequestDeviceOutcome" type="int">
+ <int value="0" label="Success"/>
+ <int value="1" label="No Bluetooth adapter"/>
+ <int value="2" label="No RenderFrameHost for message source"/>
+ <int value="3" label="Discovery start failed"/>
+ <int value="4" label="Discovery stop failed"/>
+ <int value="5" label="No matching devices found"/>
+ <int value="6" label="Bluetooth Adapter not present"/>
+ <int value="7" label="Bluetooth Adapter was off"/>
+</enum>
+
<enum name="WebFontCacheHit" type="int">
<int value="0" label="Miss"/>
<int value="1" label="Hit"/>

Powered by Google App Engine
This is Rietveld 408576698