Issue 1261533004: Reland^3 "Enable loads and stores to global vars through property cell shortcuts installed into par…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1261533004: Reland^3 "Enable loads and stores to global vars through property cell shortcuts installed into par… (Closed)

Created:
5 years, 4 months ago by Benedikt Meurer

Modified:
5 years, 4 months ago

Reviewers:
Michael Hablich

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Reland^3 "Enable loads and stores to global vars through property cell shortcuts installed into par… (patchset #1 id:1 of https://codereview.chromium.org/1254723004/)" This reverts commit 2c16d81b256ed664c376342313558a37bbce0131. R=hablich@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/a57ee763bd1c9a0340b85ad7ba4036820b3942b5

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/flag-definitions.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Michael Hablich

On 2015/07/30 08:55:01, Benedikt Meurer wrote: > PTAL lgtm consider a notreecheck=true so it gets ...

5 years, 4 months ago (2015-07-30 08:56:02 UTC) #3

Benedikt Meurer

5 years, 4 months ago (2015-07-30 08:59:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a57ee763bd1c9a0340b85ad7ba4036820b3942b5 (tree was closed).