Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1261523002: build/config: No need to handle direct_dependent_configs in GN build. (Closed)

Created:
5 years, 5 months ago by tfarina
Modified:
5 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

build/config: No need to handle direct_dependent_configs in GN build. direct_dependent_configs is the deprecated name for public_configs, and public_configs is already handled. gn-dev thread: https://groups.google.com/a/chromium.org/d/topic/gn-dev/h9N85MIx_Bk/discussion BUG=None TEST=gn gen out-gn/Release --args='is_debug=false is_component_build=false symbol_level=1' R=brettw@chromium.org Committed: https://crrev.com/65c461c8e9c02230fda24736ef77eedf51fa675c Cr-Commit-Position: refs/heads/master@{#340524}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M build/config/BUILDCONFIG.gn View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
5 years, 5 months ago (2015-07-24 23:05:41 UTC) #1
brettw
lgtm
5 years, 5 months ago (2015-07-24 23:36:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261523002/1
5 years, 4 months ago (2015-07-27 18:33:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-27 19:09:48 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 19:10:50 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65c461c8e9c02230fda24736ef77eedf51fa675c
Cr-Commit-Position: refs/heads/master@{#340524}

Powered by Google App Engine
This is Rietveld 408576698