Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 12615005: Fix heap snapshot creation for Harmony collections. (Closed)

Created:
7 years, 9 months ago by Michael Starzinger
Modified:
7 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Fix heap snapshot creation for Harmony collections. R=yangguo@chromium.org BUG=v8:2535 TEST=cctest/test-api/Regress2535 Committed: http://code.google.com/p/v8/source/detail?r=13897

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M src/objects-inl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 9 months ago (2013-03-11 10:56:59 UTC) #1
Yang
On 2013/03/11 10:56:59, Michael Starzinger wrote: LGTM.
7 years, 9 months ago (2013-03-11 11:29:30 UTC) #2
Michael Starzinger
7 years, 9 months ago (2013-03-11 11:32:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r13897 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698