Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 1261473002: PPC: [stubs] Optimize LoadGlobalViaContextStub and StoreGlobalViaContextStub. (Closed)

Created:
5 years, 4 months ago by MTBrandyberry
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [stubs] Optimize LoadGlobalViaContextStub and StoreGlobalViaContextStub. Port d6ee366d5c5aef7c6bc550889a33520058b4e33a Original commit message: This is the initial round of optimizations for the LoadGlobalViaContextStub and StoreGlobalViaContextStub, basically turning them into platform code stubs to avoid the Crankshaft overhead in the fast case, and making the runtime interface cheaper. R=bmeurer@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:510694 LOG=n Committed: https://crrev.com/4ad22295d41fd6f5cd40d8aa11c34c733c62fc30 Cr-Commit-Position: refs/heads/master@{#29867}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -49 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +31 lines, -23 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 2 chunks +157 lines, -1 line 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 2 chunks +32 lines, -21 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
MTBrandyberry
5 years, 4 months ago (2015-07-24 19:56:06 UTC) #1
dstence
lgtm
5 years, 4 months ago (2015-07-24 21:06:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261473002/1
5 years, 4 months ago (2015-07-24 21:09:58 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/4453)
5 years, 4 months ago (2015-07-24 21:16:01 UTC) #6
MTBrandyberry
On 2015/07/24 21:16:01, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 4 months ago (2015-07-24 21:34:15 UTC) #8
Benedikt Meurer
lgtm
5 years, 4 months ago (2015-07-27 10:50:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261473002/1
5 years, 4 months ago (2015-07-27 10:50:37 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-27 11:19:52 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 11:20:19 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ad22295d41fd6f5cd40d8aa11c34c733c62fc30
Cr-Commit-Position: refs/heads/master@{#29867}

Powered by Google App Engine
This is Rietveld 408576698