Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1261463005: Add assertion/crash test for flexbox with relpos with scrollable with abspos. (Closed)

Created:
5 years, 4 months ago by mstensho (USE GERRIT)
Modified:
5 years, 3 months ago
Reviewers:
cbiesinger
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Add assertion/crash test for flexbox with relpos with scrollable with abspos. This test (attached to bug 498969) used to assert, but got fixed by accident by the fix for bug 498770. Better add the test, in case it should regress. BUG=498969 R=cbiesinger@chromium.org Committed: https://crrev.com/169f80b557c2d4c83479c058073b2225270ae4da git-svn-id: svn://svn.chromium.org/blink/trunk@199646 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : Moved test to the correct directory. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
A LayoutTests/css3/flexbox/relpos-with-scrollable-with-abspos-crash.html View 1 1 chunk +16 lines, -0 lines 0 comments Download
A + LayoutTests/css3/flexbox/relpos-with-scrollable-with-abspos-crash-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mstensho (USE GERRIT)
5 years, 4 months ago (2015-07-28 10:29:09 UTC) #1
cbiesinger
You'd think that fast/flexbox is for the flexbox tests. However, they are actually for the ...
5 years, 4 months ago (2015-07-28 15:04:17 UTC) #2
mstensho (USE GERRIT)
On 2015/07/28 15:04:17, cbiesinger wrote: > You'd think that fast/flexbox is for the flexbox tests. ...
5 years, 4 months ago (2015-07-29 08:12:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261463005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261463005/20001
5 years, 4 months ago (2015-07-29 08:12:44 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=199646
5 years, 4 months ago (2015-07-29 09:25:59 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:53:04 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/169f80b557c2d4c83479c058073b2225270ae4da

Powered by Google App Engine
This is Rietveld 408576698