Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 1261453004: Check whether a typed array was neutered before writing to it (Closed)

Created:
5 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Check whether a typed array was neutered before writing to it As demanded by the spec. BUG=chromium:516251 R=jkummerow@chromium.org LOG=n Committed: https://crrev.com/ed3e5d1f3a57ad1756b4276235e1a72033f2f16f Cr-Commit-Position: refs/heads/master@{#29981}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/objects.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
jochen (gone - plz use gerrit)
5 years, 4 months ago (2015-08-03 15:30:53 UTC) #1
Jakob Kummerow
LGTM. I can haz regression test?
5 years, 4 months ago (2015-08-03 16:06:00 UTC) #2
jochen (gone - plz use gerrit)
On 2015/08/03 at 16:06:00, jkummerow wrote: > LGTM. I can haz regression test? i tried, ...
5 years, 4 months ago (2015-08-03 16:07:21 UTC) #3
Jakob Kummerow
On 2015/08/03 16:07:21, jochen wrote: > On 2015/08/03 at 16:06:00, jkummerow wrote: > > LGTM. ...
5 years, 4 months ago (2015-08-03 16:08:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261453004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261453004/20001
5 years, 4 months ago (2015-08-03 16:09:26 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-03 16:11:22 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 16:11:38 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ed3e5d1f3a57ad1756b4276235e1a72033f2f16f
Cr-Commit-Position: refs/heads/master@{#29981}

Powered by Google App Engine
This is Rietveld 408576698