Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 126143006: Revert "cc: Simplify raster task completion notification logic" (Closed)

Created:
6 years, 11 months ago by ernstm
Modified:
6 years, 11 months ago
Reviewers:
reveman, Sami, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Revert "cc: Simplify raster task completion notification logic" This CL causes Chrome to freeze on e.g. jsfiddle.net/r8dx9/1/embedded/result See crbug.com/331534 for details. > cc: Simplify raster task completion notification logic > > Previously the pixel buffer raster worker pool used a combination of > polling and explicit notifications from the raster worker pool to decide > when to tell the client about the completion of 1) all tasks or 2) the > subset of tasks required for activation. This patch simplifies the logic > by only triggering the notification based on the OnRasterTasksFinished > and OnRasterTasksRequiredForActivationFinished calls from the worker > pool. > > BUG=307841 > > Review URL: https://codereview.chromium.org/99873007 R=reveman@chromium.org,skyostil@chromium.org BUG=331534 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M cc/resources/pixel_buffer_raster_worker_pool.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/resources/pixel_buffer_raster_worker_pool.cc View 6 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ernstm
PTAL
6 years, 11 months ago (2014-01-07 22:31:47 UTC) #1
enne (OOO)
lgtm
6 years, 11 months ago (2014-01-07 22:42:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/126143006/1
6 years, 11 months ago (2014-01-07 22:46:36 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242842
6 years, 11 months ago (2014-01-08 01:17:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/126143006/1
6 years, 11 months ago (2014-01-08 01:20:13 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242965
6 years, 11 months ago (2014-01-08 03:32:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/126143006/1
6 years, 11 months ago (2014-01-08 06:00:53 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 13:00:26 UTC) #8
Message was sent while issue was closed.
Change committed as 243545

Powered by Google App Engine
This is Rietveld 408576698