Disable the "run all plugins" link on the plugins settings bubble if the setting is managed.

If the plugins setting is managed and can't be controlled by the user, then disable the run all plugins link on the plugins settings bubble.

BUG=321772
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243639

[markusheintz_, 2014-01-07 17:58:53]

Hey Bernhard, could you please take a look at this small CL?

Thanks a lot.

[Bernhard Bauer, 2014-01-07 18:07:55]

https://codereview.chromium.org/126143002/diff/90001/chrome/browser/ui/conten...
File chrome/browser/ui/content_settings/content_setting_bubble_model.cc (right):

https://codereview.chromium.org/126143002/diff/90001/chrome/browser/ui/conten...
chrome/browser/ui/content_settings/content_setting_bubble_model.cc:458:
set_custom_link_enabled(false);
There is a way to combine these logical expressions ("custom link is enabled
iff...") :)

https://codereview.chromium.org/126143002/diff/90001/chrome/browser/ui/conten...
File chrome/browser/ui/content_settings/content_setting_bubble_model.h (right):

https://codereview.chromium.org/126143002/diff/90001/chrome/browser/ui/conten...
chrome/browser/ui/content_settings/content_setting_bubble_model.h:160: bool
managed_setting() { return managed_setting_; }
Nit: Can you put the method body on a new line?

https://codereview.chromium.org/126143002/diff/90001/chrome/browser/ui/conten...
chrome/browser/ui/content_settings/content_setting_bubble_model.h:172: bool
managed_setting_;
It's not clear what this flag means from the name (is the variable the setting
that is managed?). Maybe call it |setting_is_managed|?

[markusheintz_, 2014-01-07 18:42:21]

https://codereview.chromium.org/126143002/diff/90001/chrome/browser/ui/conten...
File chrome/browser/ui/content_settings/content_setting_bubble_model.cc (right):

https://codereview.chromium.org/126143002/diff/90001/chrome/browser/ui/conten...
chrome/browser/ui/content_settings/content_setting_bubble_model.cc:458:
set_custom_link_enabled(false);
On 2014/01/07 18:08:00, Bernhard Bauer wrote:
> There is a way to combine these logical expressions ("custom link is enabled
> iff...") :)

Done.

https://codereview.chromium.org/126143002/diff/90001/chrome/browser/ui/conten...
File chrome/browser/ui/content_settings/content_setting_bubble_model.h (right):

https://codereview.chromium.org/126143002/diff/90001/chrome/browser/ui/conten...
chrome/browser/ui/content_settings/content_setting_bubble_model.h:160: bool
managed_setting() { return managed_setting_; }
On 2014/01/07 18:08:00, Bernhard Bauer wrote:
> Nit: Can you put the method body on a new line?

Done.

https://codereview.chromium.org/126143002/diff/90001/chrome/browser/ui/conten...
chrome/browser/ui/content_settings/content_setting_bubble_model.h:172: bool
managed_setting_;
On 2014/01/07 18:08:00, Bernhard Bauer wrote:
> It's not clear what this flag means from the name (is the variable the setting
> that is managed?). Maybe call it |setting_is_managed|?

Done.

[Bernhard Bauer, 2014-01-07 18:54:04]

LGTM, just a comment nit:

https://codereview.chromium.org/126143002/diff/180001/chrome/browser/ui/conte...
File chrome/browser/ui/content_settings/content_setting_bubble_model.h (right):

https://codereview.chromium.org/126143002/diff/180001/chrome/browser/ui/conte...
chrome/browser/ui/content_settings/content_setting_bubble_model.h:174: // A flag
that indicates if the content setting is managed and can't be
"managed" == "can't be controlled by the user", right? So, if you have an "and"
here, someone might mistake that for a logical conjunction :) You could use
"i.e." to make it clear that the latter is an explanation of the former.

[markusheintz_, 2014-01-08 08:24:36]

https://codereview.chromium.org/126143002/diff/180001/chrome/browser/ui/conte...
File chrome/browser/ui/content_settings/content_setting_bubble_model.h (right):

https://codereview.chromium.org/126143002/diff/180001/chrome/browser/ui/conte...
chrome/browser/ui/content_settings/content_setting_bubble_model.h:174: // A flag
that indicates if the content setting is managed and can't be
On 2014/01/07 18:54:05, Bernhard Bauer wrote:
> "managed" == "can't be controlled by the user", right? So, if you have an
"and"
> here, someone might mistake that for a logical conjunction :) You could use
> "i.e." to make it clear that the latter is an explanation of the former.

Good point. I replaced "and" with "i.e". Thanks for the suggestion.

[commit-bot: I haz the power, 2014-01-08 08:26:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markusheintz@chromium.org/126143002/27...

[commit-bot: I haz the power, 2014-01-08 08:33:19]

Retried try job too often on linux_rel for step(s) base_unittests,
browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps,
check_deps2git, chromedriver_unittests, components_unittests,
content_browsertests, content_unittests, crypto_unittests,
google_apis_unittests, gpu_unittests, interactive_ui_tests, ipc_tests,
jingle_unittests, media_unittests, nacl_integration, net_unittests,
ppapi_unittests, printing_unittests, remoting_unittests,
sandbox_linux_unittests, sql_unittests, sync_integration_tests, sync_unit_tests,
unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2014-01-08 19:44:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markusheintz@chromium.org/126143002/27...

[commit-bot: I haz the power, 2014-01-08 20:44:55]

Change committed as 243639