Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1261423002: Media: Nicer MSE append logging (Closed)

Created:
5 years, 4 months ago by servolk
Modified:
5 years, 4 months ago
Reviewers:
wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media: Nicer MSE append logging Make MSE append logging a little nicer by not repeating redundant information if the video stream doesn't contain B-frames and presentation timestamps match decode timestamps. BUG=none Committed: https://crrev.com/27ee45cba92dd4c6297233e341580d8d6e1c5cd9 Cr-Commit-Position: refs/heads/master@{#341200}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Moved BufferQueueToLogString to anonymous namespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M media/filters/source_buffer_stream.cc View 1 2 chunks +22 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
servolk
5 years, 4 months ago (2015-07-30 01:09:07 UTC) #2
wolenetz
lgtm % nit https://codereview.chromium.org/1261423002/diff/1/media/filters/source_buffer_stream.cc File media/filters/source_buffer_stream.cc (right): https://codereview.chromium.org/1261423002/diff/1/media/filters/source_buffer_stream.cc#newcode222 media/filters/source_buffer_stream.cc:222: static std::string BufferQueueToLogString( nit: s/static/...move to ...
5 years, 4 months ago (2015-07-30 18:55:15 UTC) #3
servolk
https://codereview.chromium.org/1261423002/diff/1/media/filters/source_buffer_stream.cc File media/filters/source_buffer_stream.cc (right): https://codereview.chromium.org/1261423002/diff/1/media/filters/source_buffer_stream.cc#newcode222 media/filters/source_buffer_stream.cc:222: static std::string BufferQueueToLogString( On 2015/07/30 18:55:15, wolenetz wrote: > ...
5 years, 4 months ago (2015-07-30 19:46:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261423002/20001
5 years, 4 months ago (2015-07-30 19:47:34 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-30 21:47:25 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 21:48:05 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/27ee45cba92dd4c6297233e341580d8d6e1c5cd9
Cr-Commit-Position: refs/heads/master@{#341200}

Powered by Google App Engine
This is Rietveld 408576698