Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issue 1261383002: Subzero. Moves code around in preparations for 64-bit lowering. (Closed)

Created:
5 years, 4 months ago by John
Modified:
5 years, 4 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero. Moves code around in preparations for 64-bit lowering. Specifically, it moves lowerArguments lowerRet addProlog addEpilog from the x86 lowering template to the concrete lowering implementations. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4077 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=729b5f6cf2dec861f70db54d02f245f4338f5e60

Patch Set 1 : Moves lowerArguments #

Patch Set 2 : Another painful merge. #

Patch Set 3 : Removes ifdef'd code. #

Patch Set 4 : #

Patch Set 5 : Moves lowerRet #

Patch Set 6 : Moves addProlog #

Patch Set 7 : Moves addEpilog #

Patch Set 8 : Moves methods in TargetLoweringX8632.cpp so they match TargetLoweringX8664.cpp #

Total comments: 4

Patch Set 9 : Addresses comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+969 lines, -606 lines) Patch
M src/IceInstX8664.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/IceTargetLoweringX8632.h View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 1 2 3 4 5 6 7 8 3 chunks +557 lines, -227 lines 0 comments Download
M src/IceTargetLoweringX8664.h View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M src/IceTargetLoweringX8664.cpp View 1 2 3 4 5 6 7 8 3 chunks +400 lines, -41 lines 0 comments Download
M src/IceTargetLoweringX86Base.h View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M src/IceTargetLoweringX86BaseImpl.h View 1 2 3 4 5 6 7 8 4 chunks +2 lines, -331 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
John
5 years, 4 months ago (2015-08-05 20:29:50 UTC) #2
Jim Stichnoth
lgtm https://codereview.chromium.org/1261383002/diff/140001/src/IceTargetLoweringX8632.cpp File src/IceTargetLoweringX8632.cpp (right): https://codereview.chromium.org/1261383002/diff/140001/src/IceTargetLoweringX8632.cpp#newcode201 src/IceTargetLoweringX8632.cpp:201: case IceType_void: Wasn't there discussion on another CL ...
5 years, 4 months ago (2015-08-06 13:49:19 UTC) #3
John
https://codereview.chromium.org/1261383002/diff/140001/src/IceTargetLoweringX8632.cpp File src/IceTargetLoweringX8632.cpp (right): https://codereview.chromium.org/1261383002/diff/140001/src/IceTargetLoweringX8632.cpp#newcode201 src/IceTargetLoweringX8632.cpp:201: case IceType_void: On 2015/08/06 13:49:19, stichnot wrote: > Wasn't ...
5 years, 4 months ago (2015-08-06 14:44:09 UTC) #4
John
5 years, 4 months ago (2015-08-06 14:44:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #9 (id:160001) manually as
729b5f6cf2dec861f70db54d02f245f4338f5e60 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698