Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1261373006: Grow heap slowly after running memory reducer. (Closed)

Created:
5 years, 4 months ago by ulan
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Grow heap slowly after running memory reducer. BUG= Committed: https://crrev.com/d8ad147944bf761f322482f68b804454321ac245 Cr-Commit-Position: refs/heads/master@{#29987}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M src/heap/heap.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/heap/memory-reducer.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/memory-reducer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/unittests/heap/memory-reducer-unittest.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
ulan
PTAL
5 years, 4 months ago (2015-08-03 15:28:55 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 4 months ago (2015-08-03 15:56:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261373006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261373006/20001
5 years, 4 months ago (2015-08-03 15:59:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/2933) v8_linux64_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 4 months ago (2015-08-03 16:12:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261373006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261373006/40001
5 years, 4 months ago (2015-08-03 18:05:00 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/8355)
5 years, 4 months ago (2015-08-03 18:15:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261373006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261373006/60001
5 years, 4 months ago (2015-08-03 18:20:27 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 4 months ago (2015-08-03 18:45:48 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 18:46:05 UTC) #17
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/d8ad147944bf761f322482f68b804454321ac245
Cr-Commit-Position: refs/heads/master@{#29987}

Powered by Google App Engine
This is Rietveld 408576698