Part 1 of merging Extensions and DOMUI

In this episode, we implement the DOMUI interface for extension views that are rendered in the main tab contents area. This gets us loaded and unloaded at the right place and removes many special cases for extensions from the RenderViewHost and RenderViewHostDelegate hierarchy.

BUG=13936

[Matt Perry, 2009-06-29 23:17:11]

Awesome to the max.  Thanks for taking this on.

http://codereview.chromium.org/126137/diff/3054/2027
File chrome/browser/dom_ui/dom_ui_factory.cc (right):

http://codereview.chromium.org/126137/diff/3054/2027#newcode102
Line 102: url.SchemeIs(chrome::kExtensionScheme);
there's a few places in the code where we check for the extension scheme, when
we really probably mean HasDOMUIScheme

http://codereview.chromium.org/126137/diff/3054/2030
File chrome/browser/extensions/extension_function_dispatcher.cc (right):

http://codereview.chromium.org/126137/diff/3054/2030#newcode171
Line 171: std::set<ExtensionFunctionDispatcher*>*
ExtensionFunctionDispatcher::all_instances() {
line length

http://codereview.chromium.org/126137/diff/3054/2031
File chrome/browser/extensions/extension_function_dispatcher.h (right):

http://codereview.chromium.org/126137/diff/3054/2031#newcode13
Line 13: #include "base/values.h"
this doesn't seem to be used

http://codereview.chromium.org/126137/diff/3054/2041
File chrome/browser/tab_contents/render_view_host_manager.cc (right):

http://codereview.chromium.org/126137/diff/3054/2041#newcode298
Line 298: if (cur_entry->url().SchemeIs(chrome::kExtensionScheme) !=
We shouldn't need this now that kExtensionScheme is a DOMUI scheme, right?
...
Oh wait, we need it to handle the case of navigating between chrome: and
chrome-extension: URLs.  Kinda scary.  Maybe HasDOMUIScheme() should turn into
GetBindingsForScheme() or something, so we can compare more accurately.

http://codereview.chromium.org/126137/diff/3054/2043
File chrome/browser/tab_contents/tab_contents.h (right):

http://codereview.chromium.org/126137/diff/3054/2043#newcode147
Line 147: return GetURL().SchemeIs(chrome::kExtensionScheme);
could also check for rvh_manager->dom_ui?

[Aaron Boodman, 2009-06-30 01:10:17]

http://codereview.chromium.org/126137/diff/3054/2027
File chrome/browser/dom_ui/dom_ui_factory.cc (right):

http://codereview.chromium.org/126137/diff/3054/2027#newcode102
Line 102: url.SchemeIs(chrome::kExtensionScheme);
On 2009/06/29 23:17:11, Matt Perry wrote:
> there's a few places in the code where we check for the extension scheme, when
> we really probably mean HasDOMUIScheme

Really? Like what?

http://codereview.chromium.org/126137/diff/3054/2030
File chrome/browser/extensions/extension_function_dispatcher.cc (right):

http://codereview.chromium.org/126137/diff/3054/2030#newcode171
Line 171: std::set<ExtensionFunctionDispatcher*>*
ExtensionFunctionDispatcher::all_instances() {
On 2009/06/29 23:17:11, Matt Perry wrote:
> line length

Done.

http://codereview.chromium.org/126137/diff/3054/2031
File chrome/browser/extensions/extension_function_dispatcher.h (right):

http://codereview.chromium.org/126137/diff/3054/2031#newcode13
Line 13: #include "base/values.h"
On 2009/06/29 23:17:11, Matt Perry wrote:
> this doesn't seem to be used 

Done.

http://codereview.chromium.org/126137/diff/3054/2041
File chrome/browser/tab_contents/render_view_host_manager.cc (right):

http://codereview.chromium.org/126137/diff/3054/2041#newcode298
Line 298: if (cur_entry->url().SchemeIs(chrome::kExtensionScheme) !=
On 2009/06/29 23:17:11, Matt Perry wrote:
> We shouldn't need this now that kExtensionScheme is a DOMUI scheme, right?
> ...
> Oh wait, we need it to handle the case of navigating between chrome: and
> chrome-extension: URLs.  Kinda scary.  Maybe HasDOMUIScheme() should turn into
> GetBindingsForScheme() or something, so we can compare more accurately.

I added a more correct version of this logic back. The only way I can get it to
run is by adding a link to a chrome extension page in a chrome:// page and
making sure that extension isn't already running when it is clicked.

http://codereview.chromium.org/126137/diff/3054/2043
File chrome/browser/tab_contents/tab_contents.h (right):

http://codereview.chromium.org/126137/diff/3054/2043#newcode147
Line 147: return GetURL().SchemeIs(chrome::kExtensionScheme);
On 2009/06/29 23:17:11, Matt Perry wrote:
> could also check for rvh_manager->dom_ui?

No, because then it would return true, for eg, NTP.

[Matt Perry, 2009-06-30 17:49:59]

http://codereview.chromium.org/126137/diff/2081/2101
File chrome/browser/renderer_host/render_view_host_manager.cc (right):

http://codereview.chromium.org/126137/diff/2081/2101#newcode309
Line 309: 
nit: extra line