Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 12613007: Harden Function()'s parsing of function literals. (Closed)

Created:
7 years, 9 months ago by Michael Starzinger
Modified:
7 years, 9 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Harden Function()'s parsing of function literals. R=rossberg@chromium.org BUG=v8:2470 TEST=mjsunit/regress/regress-2470 Committed: http://code.google.com/p/v8/source/detail?r=13867

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Andreas Rossberg. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -28 lines) Patch
M src/compiler.h View 5 chunks +19 lines, -4 lines 0 comments Download
M src/compiler.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/parser.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 5 chunks +8 lines, -2 lines 0 comments Download
M src/v8natives.js View 1 2 chunks +7 lines, -3 lines 0 comments Download
M test/mjsunit/new-function.js View 1 chunk +2 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-2470.js View 1 chunk +12 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
7 years, 9 months ago (2013-03-07 14:44:28 UTC) #1
rossberg
LGTM with nit https://codereview.chromium.org/12613007/diff/1/src/v8natives.js File src/v8natives.js (right): https://codereview.chromium.org/12613007/diff/1/src/v8natives.js#newcode1710 src/v8natives.js:1710: p += '\n\x2f\x2a*/'; It would be ...
7 years, 9 months ago (2013-03-07 15:08:17 UTC) #2
Michael Starzinger
Addressed comments. Landing. https://codereview.chromium.org/12613007/diff/1/src/v8natives.js File src/v8natives.js (right): https://codereview.chromium.org/12613007/diff/1/src/v8natives.js#newcode1710 src/v8natives.js:1710: p += '\n\x2f\x2a*/'; On 2013/03/07 15:08:18, ...
7 years, 9 months ago (2013-03-07 15:37:36 UTC) #3
Michael Starzinger
7 years, 9 months ago (2013-03-07 15:46:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r13867 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698