Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 12613004: To fully support hydrogen code stubs which accept a variable number of arguments, (Closed)

Created:
7 years, 9 months ago by mvstanton
Modified:
7 years, 9 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

To fully support hydrogen code stubs which accept a variable number of arguments, the HReturn/LReturn instruction needs to be able to determine argument count from a stack evaluation rather than as a constant from scope. R=danno@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13888

Patch Set 1 #

Total comments: 19

Patch Set 2 : Review updates and ports #

Patch Set 3 : Its possible to eliminate an add instruction on ARM #

Patch Set 4 : The start environment for a hydrogen stub is initialized twice (fixed). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -74 lines) Patch
M src/arm/lithium-arm.h View 1 1 chunk +12 lines, -2 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 1 chunk +11 lines, -3 lines 0 comments Download
M src/code-stubs.h View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 2 3 13 chunks +53 lines, -34 lines 0 comments Download
M src/hydrogen.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 2 3 4 chunks +17 lines, -9 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 chunks +39 lines, -11 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 1 chunk +13 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +9 lines, -3 lines 0 comments Download
M src/x64/lithium-x64.h View 1 1 chunk +12 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
mvstanton
Hi Danno, here is the HReturn change. As discussed, follow ups will be in deoptimizer ...
7 years, 9 months ago (2013-03-07 13:30:13 UTC) #1
danno
Here ya go! https://codereview.chromium.org/12613004/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/12613004/diff/1/src/hydrogen-instructions.h#newcode1483 src/hydrogen-instructions.h:1483: HReturn(HValue* value, HValue* context, int parameter_count) ...
7 years, 9 months ago (2013-03-07 15:11:14 UTC) #2
mvstanton
Hi Danno, thanks for the good advice. It is cleaner now. All the best, --Michael ...
7 years, 9 months ago (2013-03-07 16:48:49 UTC) #3
mvstanton
Hi Danno, I fixed that issue discussed earlier today in the checked in code where ...
7 years, 9 months ago (2013-03-08 13:21:44 UTC) #4
danno
7 years, 9 months ago (2013-03-08 15:10:04 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698