Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 1261253003: Don't route mouse wheel events to transparent children (Legacy_RenderWidgetHostHWND). (Closed)

Created:
5 years, 4 months ago by ananta
Modified:
5 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't route mouse wheel events to transparent children (Legacy_RenderWidgetHostHWND). Mouse wheel events on Windows would get routed to the window at the current location if it is in the same process. The message is routed via the SendMessage call. Scrolling via the wheel on a webpage would end up routing the mouse wheel message received for the main window to the the legacy window which would then callback into the main window. While the SendMessage call within the same thread works like a function call, processing the whole callstack twice causes a lot of jank while scrolling. Fix is to ignore transparent children in the RerouteMouseWheel function. BUG=462132 Committed: https://crrev.com/00f5034604fa8073643730299362b2b455e4ada0 Cr-Commit-Position: refs/heads/master@{#341047}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M ui/base/win/mouse_wheel_util.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
ananta
5 years, 4 months ago (2015-07-29 02:28:34 UTC) #2
sky
LGTM
5 years, 4 months ago (2015-07-29 17:27:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261253003/1
5 years, 4 months ago (2015-07-30 00:58:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-30 02:17:49 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 02:18:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00f5034604fa8073643730299362b2b455e4ada0
Cr-Commit-Position: refs/heads/master@{#341047}

Powered by Google App Engine
This is Rietveld 408576698