Issue 126123004: Remove no longer used methods nextAncestorSibling() from NodeTraversal.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126123004: Remove no longer used methods nextAncestorSibling() from NodeTraversal.h (Closed)

Created:
6 years, 11 months ago by atreat

Modified:
6 years, 11 months ago

Reviewers:
esprehn, Inactive, eseidel

CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, lgombos

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove no longer used methods nextAncestorSibling() from NodeTraversal.h These methods are no longer used and should be removed. They were previously used by the traverseNextTemplate methods that have since been merged into wtf/TreeNode.h. BUG=331880 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164639

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -26 lines)			Patch
	M	Source/core/dom/NodeTraversal.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	Source/core/dom/NodeTraversal.cpp	View		1 chunk	+0 lines, -23 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

atreat

On 2014/01/07 20:18:51, atreat wrote: > Remove unnecessary code after Issue 125503002 lands. NOTE: I ...

6 years, 11 months ago (2014-01-07 20:19:53 UTC) #2

eseidel

Lgtm On Tuesday, January 7, 2014, wrote: > https://codereview.chromium.org/126123004/ > To unsubscribe from this group ...

6 years, 11 months ago (2014-01-07 20:25:54 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/126123004/1

6 years, 11 months ago (2014-01-07 22:48:52 UTC) #5

Message was sent while issue was closed.

Change committed as 164639

Expand Messages | Collapse Messages