Show connection type in web-app.

Show connection type in web-app.

This is mostly boilerplate to get the OnSessionRouteChange notification up to the web-app. The web-app then includes it in the stats panel. In the common case where all channels have the same type, it displays it as "connection: <type>"; if the types differ they are displayed individually.

BUG=134528
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243947

[Jamie, 2014-01-07 16:18:03]

ptal

[Sergey Ulanov, 2014-01-07 22:58:43]

I'm not sure if the connection type should be part of stats. Stats are normally
dynamic, while connection type doesn't change often during connection. So it
might be easier to just log this information. We have logDebugMessage handler in
the webapp already, it just needs to be hooked up to the route change
notification. That would make this change much simpler.

https://codereview.chromium.org/126123002/diff/1/remoting/client/chromoting_c...
File remoting/client/chromoting_client.cc (right):

https://codereview.chromium.org/126123002/diff/1/remoting/client/chromoting_c...
remoting/client/chromoting_client.cc:164: VLOG(1) <<
"ChromotingClient::OnRouteChanged(" << channel_name << ", "
nit: There is already VLOG() for this in ConnectionToHost(), so logging it here
again is not necessary.

https://codereview.chromium.org/126123002/diff/1/remoting/webapp/client_plugi...
File remoting/webapp/client_plugin_async.js (right):

https://codereview.chromium.org/126123002/diff/1/remoting/webapp/client_plugi...
remoting/webapp/client_plugin_async.js:225: } else if (message.method ==
'onRouteChanged') {
Instead of adding another message type can we send logDebugMessage?
Alternatively I think this information can be part of onPerfStats message.

[Jamie, 2014-01-08 11:39:33]

I wanted it to be part of the stats panel so that we could get it without
needing the user to go to the console. However, once they're in the session they
have to go to the console to open the stats panel anyway, so I don't think it's
a big deal. We can always make it prettier later.

PTAL.

https://codereview.chromium.org/126123002/diff/1/remoting/client/chromoting_c...
File remoting/client/chromoting_client.cc (right):

https://codereview.chromium.org/126123002/diff/1/remoting/client/chromoting_c...
remoting/client/chromoting_client.cc:164: VLOG(1) <<
"ChromotingClient::OnRouteChanged(" << channel_name << ", "
On 2014/01/07 22:58:43, Sergey Ulanov wrote:
> nit: There is already VLOG() for this in ConnectionToHost(), so logging it
here
> again is not necessary.

I think it's better for consistency if they are all logged in the same place.
I've moved the existing VLOG into this file but kept the log level and wording
the same; LMKWYT.

https://codereview.chromium.org/126123002/diff/1/remoting/webapp/client_plugi...
File remoting/webapp/client_plugin_async.js (right):

https://codereview.chromium.org/126123002/diff/1/remoting/webapp/client_plugi...
remoting/webapp/client_plugin_async.js:225: } else if (message.method ==
'onRouteChanged') {
On 2014/01/07 22:58:43, Sergey Ulanov wrote:
> Instead of adding another message type can we send logDebugMessage?
> Alternatively I think this information can be part of onPerfStats message. 

I've changed it to use logDebugMessage.

[Sergey Ulanov, 2014-01-08 20:32:39]

LGTM

[commit-bot: I haz the power, 2014-01-09 11:32:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/126123002/110001

[commit-bot: I haz the power, 2014-01-09 12:17:08]

Retried try job too often on android_clang_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[commit-bot: I haz the power, 2014-01-09 12:51:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/126123002/110001

[commit-bot: I haz the power, 2014-01-09 13:41:49]

Retried try job too often on android_clang_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[Jamie, 2014-01-09 14:08:13]

I forgot the Android implementation. Lambros or Sergey ptal.

[Lambros, 2014-01-09 17:34:38]

On 2014/01/09 14:08:13, Jamie wrote:
> I forgot the Android implementation. Lambros or Sergey ptal.

lgtm

It compiles fine, though I did wonder where the definition of
remoting::protocol::Transport was coming from.
Looks like libjingle_transport_factory.h #includes transport.h which it
shouldn't need - it should forward-declare StreamTransport and DatagramTransport
instead. Out of scope for this CL, though.

[commit-bot: I haz the power, 2014-01-09 17:35:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/126123002/470001

[commit-bot: I haz the power, 2014-01-09 19:10:25]

Change committed as 243947