Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1261203002: Fix signature of __nacl_irt_xx functions (Closed)

Created:
5 years, 4 months ago by Sam Clegg
Modified:
5 years, 4 months ago
Reviewers:
Roland McGrath
CC:
native-client-reviews_googlegroups.com, Mark Seaborn
Base URL:
https://chromium.googlesource.com/native_client/nacl-glibc.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix signature of __nacl_irt_xx functions These functions should use nacl_abi types rather than their glibc equivalents. TEST=nacl-toolchain-precise64-glibc bot BUG= https://code.google.com/p/nativeclient/issues/detail?id=4252 R=mcgrathr@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-glibc.git;a=commit;h=16e7ca5181a7d517305039ba814ec86070d1f0e2

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M sysdeps/nacl/irt.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M sysdeps/nacl/irt_syscalls.h View 2 chunks +2 lines, -3 lines 0 comments Download
M sysdeps/nacl/irt_syscalls.c View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M sysdeps/nacl/readdir.c View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Sam Clegg
5 years, 4 months ago (2015-07-29 23:17:58 UTC) #2
Roland McGrath
lgtm
5 years, 4 months ago (2015-07-29 23:38:25 UTC) #3
Sam Clegg
5 years, 4 months ago (2015-07-29 23:55:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
16e7ca5181a7d517305039ba814ec86070d1f0e2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698