Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 12612005: Revert 186627 (Closed)

Created:
7 years, 9 months ago by miu
Modified:
7 years, 9 months ago
Reviewers:
piman
CC:
chromium-reviews, yusukes+watch_chromium.org, jonathan.backer, Ian Vollick, jam, penghuang+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, James Su
Visibility:
Public.

Description

Revert 186627 Speculative revert. The tree went red at the time this change was checked in, and multiple GpuFeatureTests started failing consistently. Example failure: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@DEPS - chromium.org&testType=browser_tests&tests=GpuFeatureTest.WebGLAllowed If you look at the first Win Aura Tests (2) fail, you get the following blamelist range: 186630 to 186619. > Use gpu::Mailbox in IPCs instead of std::string > > gpu::Mailbox is safer since the size is checked in the deserializer. It's also > overall less code. > > BUG=None > > > Review URL: https://chromiumcodereview.appspot.com/12440005 TBR=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186758

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -115 lines) Patch
M cc/texture_layer_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M cc/texture_mailbox.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/texture_mailbox.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 3 chunks +2 lines, -6 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest_manager.h View 2 chunks +1 line, -5 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.cc View 2 chunks +8 lines, -0 lines 0 comments Download
MM content/browser/renderer_host/image_transport_factory.cc View 2 chunks +20 lines, -11 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 2 chunks +17 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 2 chunks +2 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 5 chunks +12 lines, -6 lines 0 comments Download
M content/common/browser_plugin/browser_plugin_messages.h View 3 chunks +2 lines, -3 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 4 chunks +3 lines, -4 lines 0 comments Download
M content/common/gpu/texture_image_transport_surface.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/common/gpu/texture_image_transport_surface.cc View 7 chunks +20 lines, -15 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.h View 2 chunks +1 line, -5 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/browser_plugin/browser_plugin_compositing_helper.h View 3 chunks +3 lines, -7 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_compositing_helper.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_manager_impl.h View 2 chunks +1 line, -5 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/mailbox_manager.h View 2 chunks +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/mailbox_manager.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/compositor/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/compositor.h View 2 chunks +2 lines, -6 lines 0 comments Download
MM ui/compositor/compositor.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/compositor/compositor.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
miu
7 years, 9 months ago (2013-03-07 19:31:43 UTC) #1
miu
7 years, 9 months ago (2013-03-07 19:32:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r186758.

Powered by Google App Engine
This is Rietveld 408576698