Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h

Issue 1261143004: Implement manifest icon downloader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix review comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
index d3af3ac1c0f8b7198f3d36d439046c2de4646e38..4cd73eb9902952fbed8f932a52c17723a6d279ff 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
@@ -23,6 +23,7 @@ class Message;
}
class GURL;
+class ManifestIconDownloader;
mlamouri (slow - plz ping) 2015/08/21 13:34:18 nit: you no longer need this
Lalit Maganti 2015/08/21 13:45:51 Done.
// Aysnchronously fetches and processes data needed to create a shortcut for an
// Android Home screen launcher.
@@ -82,13 +83,9 @@ class AddToHomescreenDataFetcher
void CreateLauncherIcon(
const favicon_base::FaviconRawBitmapResult& bitmap_result);
- // Callback run after an attempt to download manifest icon has been made. May
- // kick off the download of a favicon if it failed.
- void OnManifestIconFetched(int id,
- int http_status_code,
- const GURL& url,
- const std::vector<SkBitmap>& bitmaps,
- const std::vector<gfx::Size>& sizes);
+ // Callback run after an attempt to download manifest icon has been made. May
+ // kick off the download of a favicon if it failed (i.e. the bitmap is empty).
+ void OnManifestIconFetched(const SkBitmap& icon);
// Notifies the observer that the shortcut data is all available.
void NotifyObserver(const SkBitmap& icon);

Powered by Google App Engine
This is Rietveld 408576698