chrome/browser/android/banners/app_banner_manager_android.cc - Issue 1261143004: Implement manifest icon downloader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 1261143004: Implement manifest icon downloader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix issues raised in comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/banners/app_banner_manager_android.cc

diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc

index 9c5cb610c69c076c9a0ea5d47f83e7cc63831be3..89a7da659b2864b0f02116eb57459dfd9fff508b 100644

--- a/chrome/browser/android/banners/app_banner_manager_android.cc

+++ b/chrome/browser/android/banners/app_banner_manager_android.cc

@@ -158,7 +158,7 @@ void ForceEngagementWeightsForTesting(JNIEnv* env,

}

jboolean IsEnabled(JNIEnv* env, jclass clazz) {

- return base::FieldTrialList::FindFullName("AppBanners") == "Enabled";

+ return true /*base::FieldTrialList::FindFullName("AppBanners") == "Enabled"*/;

mlamouri (slow - plz ping) 2015/08/05 08:20:16 I assume you should remove that change, right?

Lalit Maganti 2015/08/05 14:47:13 Done.

}

} // namespace banners