chrome/browser/android/banners/app_banner_manager_android.cc - Issue 1261143004: Implement manifest icon downloader

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 1261143004: Implement manifest icon downloader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add scaling to non correct icons Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/android/banners/app_banner_data_fetcher_android.cc ('k') | chrome/browser/banners/app_banner_data_fetcher.h » ('j') | chrome/browser/banners/app_banner_data_fetcher.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/android/banners/app_banner_manager_android.h"	5 #include "chrome/browser/android/banners/app_banner_manager_android.h"

6	6

7 #include "base/android/jni_android.h"	7 #include "base/android/jni_android.h"

8 #include "base/android/jni_string.h"	8 #include "base/android/jni_string.h"

9 #include "base/command_line.h"	9 #include "base/command_line.h"

10 #include "base/metrics/field_trial.h"	10 #include "base/metrics/field_trial.h"

(...skipping 140 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
151	151

152 void ForceEngagementWeightsForTesting(JNIEnv* env,	152 void ForceEngagementWeightsForTesting(JNIEnv* env,

153 jclass clazz,	153 jclass clazz,

154 jdouble direct_engagement,	154 jdouble direct_engagement,

155 jdouble indirect_engagement) {	155 jdouble indirect_engagement) {

156 AppBannerManager::ForceEngagementWeightsForTesting(direct_engagement,	156 AppBannerManager::ForceEngagementWeightsForTesting(direct_engagement,

157 indirect_engagement);	157 indirect_engagement);

158 }	158 }

159	159

160 jboolean IsEnabled(JNIEnv* env, jclass clazz) {	160 jboolean IsEnabled(JNIEnv* env, jclass clazz) {

161 return base::FieldTrialList::FindFullName("AppBanners") == "Enabled";	161 return true /base::FieldTrialList::FindFullName("AppBanners") == "Enabled"/;
	Lalit Maganti 2015/07/31 13:49:22 Temporary hack because app banners are not enabled Temporary hack because app banners are not enabled for me :( gone 2015/07/31 15:56:16 Finch flags for bannera can be manually set via th Show quoted text On 2015/07/31 13:49:22, Lalit Maganti wrote: > Temporary hack because app banners are not enabled for me :( Finch flags for bannera can be manually set via the command line flag: --force-fieldtrials="AppBanners/Enabled/"
162 }	162 }

163	163

164 } // namespace banners	164 } // namespace banners

OLD	NEW