Allow third_party deps to use res/values/layout instead of res/values/layout-v17

build/android/gyp/generate_v14_compatible_resources.py

Index: build/android/gyp/generate_v14_compatible_resources.py
diff --git a/build/android/gyp/generate_v14_compatible_resources.py b/build/android/gyp/generate_v14_compatible_resources.py
index a22400ddaf53f986fc50c4429cb61fedee5fd540..967fc96791f5488a6575d8658942d8bcb0b535a8 100755
--- a/build/android/gyp/generate_v14_compatible_resources.py
+++ b/build/android/gyp/generate_v14_compatible_resources.py
@@ -113,10 +113,14 @@ def ErrorIfStyleResourceExistsInDir(input_dir):
   for input_filename in build_utils.FindInDirectory(input_dir, '*.xml'):
     dom = ParseAndReportErrors(input_filename)
     if HasStyleResource(dom):
-      raise Exception('error: style file ' + input_filename +
-                      ' should be under ' + input_dir +
-                      '-v17 directory. Please refer to '
-                      'http://crbug.com/243952 for the details.')
+      # Allow style file so long as it contains no deprecated attributes.
+      if not 'third_party' in input_dir or (

[cjhopman, 2015/07/29 00:44:15]

I'm not a big fan of this sort of hidden special case based on the directory.

Supporting passing in an extra arg is kind of a pain, can we just skip
generating v14 resources for such a target?

This change will allow a style file that contains the bad
paddingStart/paddingEnd in third_party (paddingStart/End aren't deprecated but
do cause crashes).

We could here make the check more explicit, the only thing we don't want to
allow is a style file in this directory that contains paddingStart/paddingEnd
(or contains deprecated stuff).

[agrieve, 2015/07/29 01:55:01]

The third_party check isn't strictly necessary, but I thought it'd be good to
continue enforcing the convention of putting all styles within values-v17 for
chromium code
We do skip it for this target. The call to GenerateV14StyleResourceDom here just
tells us if the processing would be necessary (and fails if so).
Whoops. That wasn't my intention. I've updated the comment and taken out the
assert param.

+          GenerateV14StyleResourceDom(dom, input_filename,
+                                      assert_not_deprecated=False)):
+        raise Exception('error: style file ' + input_filename +
+                        ' should be under ' + input_dir +
+                        '-v17 directory. Please refer to '
+                        'http://crbug.com/243952 for the details.')
 
 
 def GenerateV14LayoutResourceDom(dom, filename, assert_not_deprecated=True):