Allow third_party deps to use res/values/layout instead of res/values/layout-v17

build/android/gyp/generate_v14_compatible_resources.py

 #!/usr/bin/env python
 #
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Convert Android xml resources to API 14 compatible.
 
 There are two reasons that we cannot just use API 17 attributes,
 so we are generating another set of resources by this script.
@@ skipping 95 matching lines @@
   root_node = IterateXmlElements(dom).next()
   return bool(root_node.nodeName == 'resources' and
               list(root_node.getElementsByTagName('style')))
 
 
 def ErrorIfStyleResourceExistsInDir(input_dir):
   """If a style resource is in input_dir, raises an exception."""
   for input_filename in build_utils.FindInDirectory(input_dir, '*.xml'):
     dom = ParseAndReportErrors(input_filename)
     if HasStyleResource(dom):
-      raise Exception('error: style file ' + input_filename +
-                      ' should be under ' + input_dir +
-                      '-v17 directory. Please refer to '
-                      'http://crbug.com/243952 for the details.')
+      # Allow style file in third_party to exist in non-v17 directories so long
+      # as they do not contain deprecated attributes.
+      if not 'third_party' in input_dir or (
+          GenerateV14StyleResourceDom(dom, input_filename)):
+        raise Exception('error: style file ' + input_filename +
+                        ' should be under ' + input_dir +
+                        '-v17 directory. Please refer to '
+                        'http://crbug.com/243952 for the details.')
 
 
 def GenerateV14LayoutResourceDom(dom, filename, assert_not_deprecated=True):
   """Convert layout resource to API 14 compatible layout resource.
 
   Args:
     dom: Parsed minidom object to be modified.
     filename: Filename that the DOM was parsed from.
     assert_not_deprecated: Whether deprecated attributes (e.g. paddingLeft) will
                            cause an exception to be thrown.
@@ skipping 181 matching lines @@
   build_utils.MakeDirectory(res_v14_dir)
 
   GenerateV14Resources(options.res_dir, res_v14_dir)
 
   if options.stamp:
     build_utils.Touch(options.stamp)
 
 if __name__ == '__main__':
   sys.exit(main())