Issue 12611026: [Mac] Record backtrace with nsexception logging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12611026: [Mac] Record backtrace with nsexception logging. (Closed)

Created:
7 years, 9 months ago by Scott Hess - ex-Googler

Modified:
7 years, 9 months ago

Reviewers:
Robert Sesek, Nico

CC:
chromium-reviews, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Mac] Record backtrace with nsexception logging. It has been suggested that the HALPropertyListener_Call_Helper() crashes may be correlated with nsexception = "NSPortTimeoutException reason connection timeout: did not receive reply". One of the whitelisted cases involves enumerating devices, so that could be related. This will record the backtrace where the exception is throwing from. BUG=158170 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189458

Patch Set 1 #

Total comments: 1

Patch Set 2 : gramma #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
M	chrome/browser/chrome_browser_application_mac.mm	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/common/crash_keys.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/common/crash_keys.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

Thakis for OWNERS. Actually, it's so trivial I should TBR it, so rsesek maybe could ...

7 years, 9 months ago (2013-03-20 23:06:14 UTC) #1

Nico

lgtm https://codereview.chromium.org/12611026/diff/1/chrome/common/crash_keys.h File chrome/common/crash_keys.h (right): https://codereview.chromium.org/12611026/diff/1/chrome/common/crash_keys.h#newcode29 chrome/common/crash_keys.h:29: // Records the current NSException as its being ...

7 years, 9 months ago (2013-03-20 23:08:19 UTC) #2

Scott Hess - ex-Googler

On 2013/03/20 23:11:11, rsesek wrote: > LGTM % it's its *pffth*

7 years, 9 months ago (2013-03-20 23:16:51 UTC) #4

Scott Hess - ex-Googler

7 years, 9 months ago (2013-03-20 23:27:14 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r189458 (presubmit successful).

Expand Messages | Collapse Messages