Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 126109: Fix all lines > 80 chars in messages.js so they are <= 80. (Closed)

Created:
11 years, 6 months ago by Matt Hanselman
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix all lines > 80 chars in messages.js so they are <= 80. I tried to follow precedence in the existing code base, but am unsure if my way of splitting long string constants is acceptable Updated 7/15 per review comments

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -23 lines) Patch
M src/messages.js View 1 9 chunks +45 lines, -23 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
LGTM with a few comments. http://codereview.chromium.org/126109/diff/1/2 File src/messages.js (right): http://codereview.chromium.org/126109/diff/1/2#newcode165 Line 165: // arbitrary limit, ...
11 years, 5 months ago (2009-07-01 16:55:05 UTC) #1
Matt Hanselman
11 years, 5 months ago (2009-07-15 02:14:21 UTC) #2
Updated per comments.  Please double-check link 890.  That's the way a "return"
is split in variables.h:181 ...

- Matt

On 2009/07/01 16:55:05, Søren Gjesse wrote:
> LGTM with a few comments.
> 
> http://codereview.chromium.org/126109/diff/1/2
> File src/messages.js (right):
> 
> http://codereview.chromium.org/126109/diff/1/2#newcode165
> Line 165: // arbitrary limit, grab a reasonable slice to report
> Please start comment with uppercase and end with a dot.
> 
> http://codereview.chromium.org/126109/diff/1/2#newcode374
> Line 374: var from_line = IS_UNDEFINED(opt_from_line)
> Please write like this:
> var from_line =
>     IS_UNDEFINED(opt_from_line) ? this.line_offset : opt_from_line;
> 
> http://codereview.chromium.org/126109/diff/1/2#newcode376
> Line 376: var to_line = IS_UNDEFINED(opt_to_line)
> See above.

Powered by Google App Engine
This is Rietveld 408576698