Skip temp texture when config conversion test has already failed.

Skip temp texture when config conversion test has already failed.

Committed: https://skia.googlesource.com/skia/+/636e8024f8df8df7b89813c8b2b1ea04d7481497

[bsalomon, 2015-07-28 20:32:29]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2015-07-28 20:32:36]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2015-07-28 20:32:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1261033005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1261033005/1

[commit-bot: I haz the power, 2015-07-28 20:32:55]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-07-29 02:32 UTC

[commit-bot: I haz the power, 2015-07-29 02:32:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-29 02:32:01]

No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer from
https://skia.googlesource.com/skia/+/master/CQ_COMMITTERS

[robertphillips, 2015-07-29 12:35:05]

lgtm + docs suggestions

https://codereview.chromium.org/1261033005/diff/1/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/1261033005/diff/1/include/gpu/GrContext.h#new...
include/gpu/GrContext.h:447: bool swapRAndB, const SkMatrix&);
// If true both createPMToUPMEffect & createUPMToPMEffect will return NULL. In
such cases Ganesh will fall back to SW.
?

https://codereview.chromium.org/1261033005/diff/1/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/1261033005/diff/1/src/gpu/GrContext.cpp#newco...
src/gpu/GrContext.cpp:727: bool GrContext::didFailPMUPMConversionTest() const {
// The PM<->UPM tests fail or succeed together so we only need to check one.
?

[bsalomon, 2015-07-29 12:58:32]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-07-29 12:58:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1261033005/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2015-07-29 12:58:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1261033005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1261033005/20001

[bsalomon, 2015-07-29 12:59:28]

The CQ bit was unchecked by bsalomon@google.com

[bsalomon, 2015-07-29 13:01:15]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-07-29 13:01:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1261033005/#ps40001
(title: "Additional Comment")

[commit-bot: I haz the power, 2015-07-29 13:01:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1261033005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1261033005/40001

[bsalomon, 2015-07-29 13:01:34]

https://codereview.chromium.org/1261033005/diff/1/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/1261033005/diff/1/include/gpu/GrContext.h#new...
include/gpu/GrContext.h:447: bool swapRAndB, const SkMatrix&);
On 2015/07/29 12:35:05, robertphillips wrote:
> // If true both createPMToUPMEffect & createUPMToPMEffect will return NULL. In
> such cases Ganesh will fall back to SW.
> ?
> 

Done.

https://codereview.chromium.org/1261033005/diff/1/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/1261033005/diff/1/src/gpu/GrContext.cpp#newco...
src/gpu/GrContext.cpp:727: bool GrContext::didFailPMUPMConversionTest() const {
On 2015/07/29 12:35:05, robertphillips wrote:
> // The PM<->UPM tests fail or succeed together so we only need to check one.
> ?

Done.

[commit-bot: I haz the power, 2015-07-29 13:08:49]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/636e8024f8df8df7b89813c8b2b1ea04d7481497