chrome/browser/ui/webui/ntp/thumbnail_list_source.cc - Issue 126103003: Changed RefCountedStaticMemory() to accept a void pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/thumbnail_list_source.cc

Issue 126103003: Changed RefCountedStaticMemory() to accept a void pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/libgtk2ui/app_indicator_icon.cc ('k') | components/web_contents_delegate_android/web_contents_delegate_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/ntp/thumbnail_list_source.cc

diff --git a/chrome/browser/ui/webui/ntp/thumbnail_list_source.cc b/chrome/browser/ui/webui/ntp/thumbnail_list_source.cc

index 69a7dfd85556cf8cef296c03a1e67a34741f8394..013244e346e791c57f74a4971b065d58a671f695 100644

--- a/chrome/browser/ui/webui/ntp/thumbnail_list_source.cc

+++ b/chrome/browser/ui/webui/ntp/thumbnail_list_source.cc

@@ -129,10 +129,8 @@ void ThumbnailListSource::OnMostVisitedURLsAvailable(

for (size_t i = 0; i < num_mv; ++i) {

scoped_refptr<base::RefCountedMemory> data;

if (thumbnail_service_->GetPageThumbnail(mvurl_list[i].url, false, &data)) {

- std::string data_str;

- data_str.assign(reinterpret_cast<const char*>(data->front()),

- data->size());

- base::Base64Encode(data_str, &base64_encoded_pngs[i]);

+ base::Base64Encode(std::string(data->front_as<char>(), data->size()),

+ &base64_encoded_pngs[i]);

++num_mv_with_thumb;

}