Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12610012: chromeos: Remove DriveResourceMetadata::RemoveDirectoryChildFiles/Directories (Closed)

Created:
7 years, 9 months ago by hashimoto
Modified:
7 years, 9 months ago
Reviewers:
kinaba
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Remove DriveResourceMetadata::RemoveDirectoryChildFiles/Directories No longer need to maintain these methods. BUG=127856 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188009

Patch Set 1 : _ #

Total comments: 2

Patch Set 2 : Add missing delete #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -37 lines) Patch
M chrome/browser/chromeos/drive/drive_resource_metadata.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_resource_metadata.cc View 1 1 chunk +8 lines, -35 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hashimoto
7 years, 9 months ago (2013-03-14 03:35:12 UTC) #1
kinaba
https://codereview.chromium.org/12610012/diff/2001/chrome/browser/chromeos/drive/drive_resource_metadata.cc File chrome/browser/chromeos/drive/drive_resource_metadata.cc (right): https://codereview.chromium.org/12610012/diff/2001/chrome/browser/chromeos/drive/drive_resource_metadata.cc#newcode757 chrome/browser/chromeos/drive/drive_resource_metadata.cc:757: Don't you need to "delete child"?
7 years, 9 months ago (2013-03-14 04:21:50 UTC) #2
hashimoto
https://codereview.chromium.org/12610012/diff/2001/chrome/browser/chromeos/drive/drive_resource_metadata.cc File chrome/browser/chromeos/drive/drive_resource_metadata.cc (right): https://codereview.chromium.org/12610012/diff/2001/chrome/browser/chromeos/drive/drive_resource_metadata.cc#newcode757 chrome/browser/chromeos/drive/drive_resource_metadata.cc:757: On 2013/03/14 04:21:50, kinaba wrote: > Don't you need ...
7 years, 9 months ago (2013-03-14 04:55:22 UTC) #3
kinaba
lgtm for Patch Set 2.
7 years, 9 months ago (2013-03-14 05:00:31 UTC) #4
hashimoto
7 years, 9 months ago (2013-03-14 07:09:55 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r188009 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698