Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: sdk/lib/_internal/compiler/implementation/dart2js.dart

Issue 12610006: Renamed StreamSink to EventSink. Renamed signalError to addError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/dart2js.dart
diff --git a/sdk/lib/_internal/compiler/implementation/dart2js.dart b/sdk/lib/_internal/compiler/implementation/dart2js.dart
index 7be2db8c25176928cfbf6536e065d8e84ef61ab2..1e0a40f0570f654bf9939c1cea50138cf67fd65c 100644
--- a/sdk/lib/_internal/compiler/implementation/dart2js.dart
+++ b/sdk/lib/_internal/compiler/implementation/dart2js.dart
@@ -262,7 +262,7 @@ void compile(List<String> argv) {
}
}
- StreamSink<String> outputProvider(String name, String extension) {
+ EventSink<String> outputProvider(String name, String extension) {
Uri uri;
String sourceMapFileName;
bool isPrimaryOutput = false;
@@ -314,20 +314,21 @@ void compile(List<String> argv) {
}
// TODO(ahe): Get rid of this class if http://dartbug.com/8118 is fixed.
-class CountingSink implements StreamSink<String> {
- final StreamSink<String> sink;
+class CountingSink implements EventSink<String> {
+ final EventSink<String> sink;
int count = 0;
CountingSink(this.sink);
- add(String value) {
+ void add(String value) {
sink.add(value);
count += value.length;
}
- signalError(AsyncError error) => sink.signalError(error);
+ void addError(AsyncError error) { sink.signalError(error); }
+ void signalError(AsyncError error) { addError(error); }
floitsch 2013/03/07 14:19:34 Ask Peter if we can remove signalError already. If
Lasse Reichstein Nielsen 2013/03/08 10:18:25 We can't remove it, it's still in the interface (d
- close() => sink.close();
+ void close() { sink.close(); }
}
class AbortLeg {

Powered by Google App Engine
This is Rietveld 408576698