Include "ffmpeg.dll" in installer archive.

Include "ffmpeg.dll" in installer archive.

By setting "ffmpeg_component=shared_library" you can build ffmpeg as library
while the rest of Chromium is statically compiled.

In this case, the "ffmpeg.dll" was not included in the installer archive which
is fixed with the CL.

Committed: https://crrev.com/8f4688108f6d839e8b8cb7b501e133e34f0cc574
Cr-Commit-Position: refs/heads/master@{#342318}

[joachim, 2015-08-04 10:22:21]

jbauch@webrtc.org changed reviewers:
+ gab@chromium.org

[joachim, 2015-08-04 10:22:37]

ptal

[gab, 2015-08-04 19:42:29]

Why isn't this also controlled by component=shared_library?

Is this only for developer builds or will this DLL ever be present standalone in
an Official build?

[joachim, 2015-08-04 20:47:07]

On 2015/08/04 19:42:29, gab wrote:
> Why isn't this also controlled by component=shared_library?
> 
> Is this only for developer builds or will this DLL ever be present standalone
in
> an Official build?

"component=shared_library" controls how Chromium is linked, this can be
overwritten for FFmpeg-only using "ffmpeg_component". I don't think this will
ever be the case for official builds, but I have that use case for a custom
Chromium build on Windows where I want to distribute two versions of FFmpeg.
One version with only the "free" codecs and one also with proprietary codecs,
similar what most Linux distributions provide. The rest of Chromium is fine to
link statically (i.e. no "component=shared_library"), but FFmpeg needs to be a
separate library so I use "ffmpeg_component=shared_library".

[gab, 2015-08-06 16:23:25]

On 2015/08/04 20:47:07, joachim wrote:
> On 2015/08/04 19:42:29, gab wrote:
> > Why isn't this also controlled by component=shared_library?
> > 
> > Is this only for developer builds or will this DLL ever be present
standalone
> in
> > an Official build?
> 
> "component=shared_library" controls how Chromium is linked, this can be
> overwritten for FFmpeg-only using "ffmpeg_component". I don't think this will
> ever be the case for official builds, but I have that use case for a custom
> Chromium build on Windows where I want to distribute two versions of FFmpeg.
> One version with only the "free" codecs and one also with proprietary codecs,
> similar what most Linux distributions provide. The rest of Chromium is fine to
> link statically (i.e. no "component=shared_library"), but FFmpeg needs to be a
> separate library so I use "ffmpeg_component=shared_library".

Ok lgtm then I guess, note this won't be sufficient if you ever need to package
this in an official Google Chrome build but for Chromium it should do it.

[joachim, 2015-08-07 07:32:06]

The CQ bit was checked by jbauch@webrtc.org

[commit-bot: I haz the power, 2015-08-07 07:32:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1260963007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1260963007/1

[commit-bot: I haz the power, 2015-08-07 08:07:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-08-07 08:08:22]

Patchset 1 (id:??) landed as
https://crrev.com/8f4688108f6d839e8b8cb7b501e133e34f0cc574
Cr-Commit-Position: refs/heads/master@{#342318}